System user #837
Merged
System user #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nullable" This reverts commit 5526edc.
norkans7
reviewed
Feb 17, 2025
| // gets the system user to use for contact audit fields | ||
| func getSystemUserID(ctx context.Context, db *sqlx.DB) (UserID, error) { | ||
| var id UserID | ||
| err := db.GetContext(ctx, &id, "SELECT id FROM users_user WHERE username = 'system'") |
There was a problem hiding this comment.
we need to filter the is_system field too not just the username?
There was a problem hiding this comment.
username is unique (globally) so there's only ever going to be one user with that username
norkans7
requested changes
Feb 17, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
==========================================
- Coverage 74.75% 74.73% -0.03%
==========================================
Files 112 113 +1
Lines 13282 13295 +13
==========================================
+ Hits 9929 9936 +7
- Misses 2640 2644 +4
- Partials 713 715 +2 ☔ View full report in Codecov by Sentry. |
norkans7
approved these changes
Feb 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.