Model quick replies as structs instead of strings #838
+196
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Feb 19, 2025
| HighPriority_ bool `json:"high_priority" db:"high_priority"` | ||
| Text_ string `json:"text" db:"text"` | ||
| Attachments_ pq.StringArray `json:"attachments" db:"attachments"` | ||
| QuickReplies_ pq.StringArray `json:"quick_replies" db:"quick_replies"` |
There was a problem hiding this comment.
we don't write or load messages with quick replies from the db
rowanseymour
commented
Feb 19, 2025
| @@ -90,7 +90,7 @@ var sendTestCases = []OutgoingTestCase{ | |||
| ExpectedRequests: []ExpectedRequest{ | |||
| { | |||
| Path: "/discord/rp/send", | |||
| Body: `{"id":"10","text":"Hello World","to":"694634743521607802","channel":"bac782c2-7aeb-4389-92f5-97887744f573","attachments":[],"quick_replies":null}`, | |||
There was a problem hiding this comment.
sending arrays as nulls doesn't seem right...
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
- Coverage 74.73% 74.65% -0.09%
==========================================
Files 113 113
Lines 13295 13308 +13
==========================================
- Hits 9936 9935 -1
- Misses 2644 2658 +14
Partials 715 715 ☔ View full report in Codecov by Sentry. |
norkans7
approved these changes
Feb 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But they can be unmarshaled from strings