Skip to content

Stop writing contactfire.extra #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion backends/rapidpro/schema.sql
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ CREATE TABLE IF NOT EXISTS contacts_contactfire (
fire_on timestamp with time zone NOT NULL,
session_uuid uuid,
sprint_uuid uuid,
extra jsonb,
UNIQUE (contact_id, fire_type, scope)
);

Expand Down
4 changes: 2 additions & 2 deletions backends/rapidpro/timeouts.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import (
type SessionID int64

const sqlInsertTimeoutFire = `
INSERT INTO contacts_contactfire(org_id, contact_id, fire_type, scope, fire_on, session_uuid, sprint_uuid, extra)
VALUES($1, $2, 'T', '', $3, $4, $5, '{}')
INSERT INTO contacts_contactfire(org_id, contact_id, fire_type, scope, fire_on, session_uuid, sprint_uuid)
VALUES($1, $2, 'T', '', $3, $4, $5)
ON CONFLICT DO NOTHING`

// insertTimeoutFire inserts a timeout fire for the session associated with the given msg
Expand Down