Add support for config to shorten URL for TMS #848
Merged
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
=======================================
Coverage 70.25% 70.25%
=======================================
Files 114 114
Lines 13106 13109 +3
=======================================
+ Hits 9207 9210 +3
Misses 3208 3208
Partials 691 691 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
handlers/twiml/handlers.go
Outdated
| @@ -348,6 +349,11 @@ func (h *handler) Send(ctx context.Context, msg courier.MsgOut, res *courier.Sen | |||
| // set our from, either as a messaging service or from our address | |||
| serviceSID := channel.StringConfigForKey(configMessagingServiceSID, "") | |||
| if serviceSID != "" { | |||
| linkShortening := channel.BoolConfigForKey(configLinkShortening, false) | |||
| if linkShortening { | |||
| form["ShortenUrls"] = []string{strconv.FormatBool(linkShortening)} | |||
There was a problem hiding this comment.
could just use []string{"true"}
rowanseymour
approved these changes
Mar 18, 2025
norkans7
force-pushed
the
tms-short-urls
branch
from
d172a33 to
cef18fc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.