Rename config for BW messaging application ID #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkans7
commented
Apr 8, 2025
| @@ -177,7 +179,10 @@ func (h *handler) Send(ctx context.Context, msg courier.MsgOut, res *courier.Sen | |||
| username := msg.Channel().StringConfigForKey(courier.ConfigUsername, "") | |||
| password := msg.Channel().StringConfigForKey(courier.ConfigPassword, "") | |||
| accountID := msg.Channel().StringConfigForKey(configAccountID, "") | |||
| applicationID := msg.Channel().StringConfigForKey(configApplicationID, "") | |||
| applicationID := msg.Channel().StringConfigForKey(configMsgApplicationID, "") | |||
| if applicationID == "" { | |||
There was a problem hiding this comment.
To support the application_id config before the migration is applied
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
==========================================
- Coverage 70.25% 70.23% -0.02%
==========================================
Files 114 114
Lines 13113 13115 +2
==========================================
- Hits 9212 9211 -1
- Misses 3210 3212 +2
- Partials 691 692 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rowanseymour
approved these changes
Apr 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the config key for BW messaging app ID