Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework getValueForNumber to also cache for unknown languages #200

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

rowanseymour
Copy link
Member

So we don't endlessly retry loading data files that don't exist.

And we don't need to return an error if match not found because calling code checks for zero values.

cc @kuadrosx

@rowanseymour rowanseymour changed the title Rework getValueForNumber to also cache where invalid prefix has missing data Rework getValueForNumber to also cache where language has missing data Mar 20, 2025
@rowanseymour rowanseymour changed the title Rework getValueForNumber to also cache where language has missing data Rework getValueForNumber to also cache for unknown languages Mar 20, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.90%. Comparing base (b8a88b8) to head (37e0f6b).

Files with missing lines Patch % Lines
phonenumbers.go 72.22% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   47.95%   47.90%   -0.06%     
==========================================
  Files          11       11              
  Lines        3818     3816       -2     
==========================================
- Hits         1831     1828       -3     
  Misses       1838     1838              
- Partials      149      150       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rowanseymour rowanseymour merged commit 23cec2c into main Mar 20, 2025
10 checks passed
@rowanseymour rowanseymour deleted the data_load_tweak branch March 20, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants