You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also corrects max output tokens for claude-sonnet-4-6 (64K → 128K).
Existing LLM records are unaffected since model and max_output_tokens are stored on the row — this only changes which models can be selected for new connections. Orgs still configured with a retired model were already broken at the provider and will need to reconnect separately.
Analyze correctness (model IDs, token limits, test coverage)
Post review
Straightforward config change. The LLM_TYPES update is consistent with the test fixtures — Anthropic/Google test mocks were updated in lockstep with the new model IDs, and every LLM.create(...) in test_llm.py / test_llmcrudl.py / api/internal/tests.py was moved off the retired claude-3-5-haiku-20241022 to claude-haiku-4-5-20251001. The filter branches in both wizard tests still exercise the "not in allowed list" path (Anthropic keeps claude-3-5-sonnet-20240620, Google keeps gemini-1.5-flash), so test coverage isn't reduced.
I can't independently verify the max_output_tokens values or that the new model IDs exactly match provider catalogs — you'll want to double-check those against Anthropic/Google/OpenAI docs before merging. The claude-sonnet-4-6 64K → 128K correction is the only field where a wrong number would silently truncate live responses (existing rows keep their stored value, but any newly-created connection would inherit the new cap).
One minor observation, non-blocking:
temba/utils/management/commands/data/mailroom_db.json:221 still seeds a claude-3-7-sonnet LLM record. This is dev-only seed data and doesn't affect prod (existing LLM.model values are untouched by the settings change, as the PR body notes), but a freshly initialized mailroom DB will reference a model that's no longer in LLM_TYPES and no longer accepted by the provider. Worth updating to claude-haiku-4-5-20251001 or another current model in a follow-up.
Nothing else stands out — no security, performance, or convention concerns.
· Branch: update-llm-models
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the default
LLM_TYPESmodel lists to reflect current provider catalogs:Removed (retired by providers, requests now fail):
claude-3-7-sonnet-20250219,claude-3-5-haiku-20241022(retired Feb 2026)gemini-2.0-flash(shut down Jun 2026),gemini-1.5-flash(1.5 series shut down)Added:
claude-opus-4-8,claude-sonnet-5gemini-3.6-flash,gemini-3.5-flash,gemini-3.5-flash-litegpt-5.6-sol,gpt-5.6-terra,gpt-5.6-lunaAlso corrects max output tokens for
claude-sonnet-4-6(64K → 128K).Existing
LLMrecords are unaffected sincemodelandmax_output_tokensare stored on the row — this only changes which models can be selected for new connections. Orgs still configured with a retired model were already broken at the provider and will need to reconnect separately.