Open
Conversation
Moving JS code to nyckml.js
Member
Author
|
Also need to merge this as the new Google Earth KML Viewer function has moved and the new environment variable (the IP address) to change. |
create new sanitize routine to parse all $_GET params
james-otten
reviewed
Apr 27, 2025
| }); | ||
| } | ||
|
|
||
| const lat_1_def = "<?php echo $lat_1 ?>"; |
Collaborator
There was a problem hiding this comment.
I'm not sure if you have this var in scope
james-otten
reviewed
Apr 27, 2025
| }).addTo(map_2); | ||
|
|
||
| marker_1.on('dragend', function(e) { | ||
| document.getElementById("coords_1").innerHTML = marker_1.getLatLng().lat + ", " + marker_1.getLatLng().lng; |
Collaborator
There was a problem hiding this comment.
Does it work to use innerText instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving JS code to nyckml.js