Update packages and fix breaking changes#53
Merged
danielhmetro merged 4 commits intomasterfrom Aug 6, 2025
Merged
Conversation
- React 17 to 19 with changes to how the render works, ReactDOM to createRoot - Highlight.js 10 to 11 with change from highlightBlock to highlightElement and loading of just RouterOS
Collaborator
Author
|
Netlify autobuild is failing: From https://answers.netlify.com/t/please-read-end-of-support-for-xenial-build-image-everything-you-need-to-know/68239 it seems the solution is to update the build image setting, specifically "upgrade to the latest build image in the Netlify UI under Site settings > Build & deploy > Continuous Deployment > Build image selection" |
Collaborator
Author
|
Nevermind, I see there's already work to move to github pages so I'll wait for this (and help how I can) and then use that |
Member
Can you just reconfirm this pull request works correctly after the change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of security updates as it hadn't been updated in a while. Running
npm auditbefore showed 138 vulnerabilities (100 moderate, 31 high, 7 critical) and now it's at 9 vulnerabilities (3 moderate, 6 high)NOTE: I'm not clear how this gets deployed, or even where it gets deployed. I'm hoping to add notes once I learn the process.
I tested locally and confirmed the app still boots up, highlighting still works, template injection still works, etc.
Some notes from development:
npm startbefore I start making changes https://stackoverflow.com/questions/75959563/node-js-err-ossl-evp-unsupported-error-when-running-npm-run-start I'm gettingopensslErrorStack: ['error:03000086:digital envelope routines::initialization error'], library: 'digital envelope routines', reason: 'unsupported', code: 'ERR_OSSL_EVP_UNSUPPORTED' }and the recommendation is to runexport NODE_OPTIONS=--openssl-legacy-providerto temporarily allow old algorithms or key sizes. Sure enough that works.Migrating from 4.0.x to 5.0.0. Unclear if we have anything to do with ejection but I'll runnpm install --save --save-exact react-scripts@5.0.0just in case.npm startwhich wasexport 'highlightBlock' (imported as 'highlightBlock') was not found in 'highlight.js'