WIP: New plugin - smartcar by gpaulbot · Pull Request #451 · nymea/nymea-plugins

gpaulbot · 2021-07-09T08:31:16Z

nymea-plugins pull request checklist:

Make sure the pull request's title is of format "Plugin name: Add support for xyz" or "New plugin: Plugin name"
Did you test the changes on hardware, if not (e.g. absence of required hardware), please mention a person to confirm it has been tested.
Did you update the plugin's README.md accordingly?
Did you update translations (cd builddir && make lupdate)?
If you added a new plugin, should it be added to nymea-plugins-all or nymea-plugins-maker?

nymea-jenkins · 2021-07-09T08:31:18Z

Can one of the admins verify this patch?

CLAassistant · 2021-07-09T08:31:21Z

All committers have signed the CLA.

mzanetti · 2021-07-09T11:28:22Z

Also, please add the dpkg files so it will be packaged by CI:

add package in debian/control
add debian/nymea-plugin-smartcar.install.in

Not sure if we need to add it to any meta package (last point from checklist), probably not as the vast majority of users out there won't have a supported car yet.

Used hashin <package> for requirements.txt Added dpkg files for smartcar package

mzanetti · 2022-02-28T16:24:11Z

+Architecture: any
+Depends: ${shlibs:Depends},
+         ${misc:Depends},
+         nymea-plugins-translations,


Latest nymea-plugins doesn't have a single translations package any more but every plugin will ship its own translations within the pluign package.

mzanetti · 2022-02-28T16:24:26Z

@@ -0,0 +1,3 @@
+smartcar/integrationpluginsmartcar.json usr/lib/@DEB_HOST_MULTIARCH@/nymea/plugins/smartcar/
+smartcar/integrationpluginsmartcar.py usr/lib/@DEB_HOST_MULTIARCH@/nymea/plugins/smartcar/
+smartcar/requirements.txt usr/lib/@DEB_HOST_MULTIARCH@/nymea/plugins/smartcar/


here, the .qm files need to be added

mzanetti · 2022-02-28T16:26:20Z

+                    "displayName": "Vehicle",
+                    "id": "77ddd9f7-7c16-4bf3-bff0-c3a2208c8c66",                    
+                    "createMethods": ["auto"],
+                    "interfaces": ["battery"],


an "electricvehicle" interface exists nowadays which should be implemented in this one.

mzanetti · 2022-02-28T16:28:10Z

+        pollTimers[thing.id] = threading.Timer(value, pollService, [thing.id])
+        pollTimers[thing.id].start()
+
+def createPollTimer(thing):    


nymea's python api gained support for nymea.PluginTimer. No need to start own threads any more.

mzanetti reviewed Jul 9, 2021

View reviewed changes

Comment thread smartcar/requirements.txt Outdated

gpaulbot force-pushed the add-smartcar branch from 9a5e833 to f329c0d Compare July 9, 2021 08:43

mzanetti added the experimental Branches with this tag will be built in the experimental track label Jul 9, 2021

nymea-jenkins added a commit that referenced this pull request Jul 9, 2021

Merge PR #451: WIP: New plugin - smartcar

0619a94

nymea-jenkins added a commit that referenced this pull request Jul 9, 2021

Merge PR #451: WIP: New plugin - smartcar

7cc2897

nymea-jenkins added a commit that referenced this pull request Jul 10, 2021

Merge PR #451: WIP: New plugin - smartcar

b270fcf

nymea-jenkins added a commit that referenced this pull request Jul 11, 2021

Merge PR #451: WIP: New plugin - smartcar

8e3cbef

nymea-jenkins added a commit that referenced this pull request Aug 2, 2021

Merge PR #451: WIP: New plugin - smartcar

cb68e75

nymea-jenkins added a commit that referenced this pull request Aug 2, 2021

Merge PR #451: WIP: New plugin - smartcar

ea4ff5c

nymea-jenkins added a commit that referenced this pull request Aug 3, 2021

Merge PR #451: WIP: New plugin - smartcar

7267828

nymea-jenkins added a commit that referenced this pull request Aug 5, 2021

Merge PR #451: WIP: New plugin - smartcar

cf07f21

nymea-jenkins added a commit that referenced this pull request Aug 5, 2021

Merge PR #451: WIP: New plugin - smartcar

a6d7862

nymea-jenkins added a commit that referenced this pull request Aug 6, 2021

Merge PR #451: WIP: New plugin - smartcar

96c121f

nymea-jenkins added a commit that referenced this pull request Aug 7, 2021

Merge PR #451: WIP: New plugin - smartcar

9e54cfa

nymea-jenkins added a commit that referenced this pull request Aug 7, 2021

Merge PR #451: WIP: New plugin - smartcar

91032c6

nymea-jenkins added a commit that referenced this pull request Aug 9, 2021

Merge PR #451: WIP: New plugin - smartcar

26bb8cd

nymea-jenkins added a commit that referenced this pull request Aug 9, 2021

Merge PR #451: WIP: New plugin - smartcar

6535720

nymea-jenkins added a commit that referenced this pull request Aug 9, 2021

Merge PR #451: WIP: New plugin - smartcar

c8fa0f3

nymea-jenkins added a commit that referenced this pull request Aug 12, 2021

Merge PR #451: WIP: New plugin - smartcar

52cde61

nymea-jenkins added a commit that referenced this pull request Aug 13, 2021

Merge PR #451: WIP: New plugin - smartcar

42dd3df

nymea-jenkins added a commit that referenced this pull request Aug 16, 2021

Merge PR #451: WIP: New plugin - smartcar

1adc355

nymea-jenkins added a commit that referenced this pull request Aug 17, 2021

Merge PR #451: WIP: New plugin - smartcar

5fe4956

nymea-jenkins added a commit that referenced this pull request Aug 17, 2021

Merge PR #451: WIP: New plugin - smartcar

6304580

nymea-jenkins added a commit that referenced this pull request Aug 17, 2021

Merge PR #451: WIP: New plugin - smartcar

0318f55

nymea-jenkins added a commit that referenced this pull request Aug 17, 2021

Merge PR #451: WIP: New plugin - smartcar

65faa40

nymea-jenkins added a commit that referenced this pull request Aug 18, 2021

Merge PR #451: WIP: New plugin - smartcar

2c64907

nymea-jenkins added a commit that referenced this pull request Aug 18, 2021

Merge PR #451: WIP: New plugin - smartcar

181ff1e

nymea-jenkins added a commit that referenced this pull request Sep 28, 2021

Merge PR #451: WIP: New plugin - smartcar

42b8651

nymea-jenkins added a commit that referenced this pull request Sep 30, 2021

Merge PR #451: WIP: New plugin - smartcar

1c4b1c0

nymea-jenkins added a commit that referenced this pull request Sep 30, 2021

Merge PR #451: WIP: New plugin - smartcar

050b0d8

nymea-jenkins added a commit that referenced this pull request Sep 30, 2021

Merge PR #451: WIP: New plugin - smartcar

cffcc7b

nymea-jenkins added a commit that referenced this pull request Sep 30, 2021

Merge PR #451: WIP: New plugin - smartcar

d958feb

nymea-jenkins added a commit that referenced this pull request Sep 30, 2021

Merge PR #451: WIP: New plugin - smartcar

e3ab5f1

nymea-jenkins added a commit that referenced this pull request Sep 30, 2021

Merge PR #451: WIP: New plugin - smartcar

ce6970f

nymea-jenkins added a commit that referenced this pull request Sep 30, 2021

Merge PR #451: WIP: New plugin - smartcar

794d879

nymea-jenkins added a commit that referenced this pull request Oct 6, 2021

Merge PR #451: WIP: New plugin - smartcar

b5459ab

nymea-jenkins added a commit that referenced this pull request Oct 12, 2021

Merge PR #451: WIP: New plugin - smartcar

3bb5e26

nymea-jenkins added a commit that referenced this pull request Oct 12, 2021

Merge PR #451: WIP: New plugin - smartcar

f7bdebc

nymea-jenkins added a commit that referenced this pull request Oct 13, 2021

Merge PR #451: WIP: New plugin - smartcar

3afc75c

nymea-jenkins added a commit that referenced this pull request Oct 15, 2021

Merge PR #451: WIP: New plugin - smartcar

a29664f

nymea-jenkins added a commit that referenced this pull request Oct 17, 2021

Merge PR #451: WIP: New plugin - smartcar

6600db3

nymea-jenkins added a commit that referenced this pull request Oct 17, 2021

Merge PR #451: WIP: New plugin - smartcar

dc381f9

nymea-jenkins added a commit that referenced this pull request Oct 21, 2021

Merge PR #451: WIP: New plugin - smartcar

b02a694

nymea-jenkins added a commit that referenced this pull request Oct 21, 2021

Merge PR #451: WIP: New plugin - smartcar

b7c282a

nymea-jenkins added a commit that referenced this pull request Oct 21, 2021

Merge PR #451: WIP: New plugin - smartcar

b90c7be

nymea-jenkins added a commit that referenced this pull request Oct 21, 2021

Merge PR #451: WIP: New plugin - smartcar

3009922

nymea-jenkins added a commit that referenced this pull request Oct 22, 2021

Merge PR #451: WIP: New plugin - smartcar

cadb3e6

nymea-jenkins added a commit that referenced this pull request Oct 22, 2021

Merge PR #451: WIP: New plugin - smartcar

8bd1856

nymea-jenkins added a commit that referenced this pull request Oct 22, 2021

Merge PR #451: WIP: New plugin - smartcar

1c7c2d5

nymea-jenkins added a commit that referenced this pull request Oct 23, 2021

Merge PR #451: WIP: New plugin - smartcar

43e6886

nymea-jenkins added a commit that referenced this pull request Oct 24, 2021

Merge PR #451: WIP: New plugin - smartcar

a328b9c

gpaulbot and others added 5 commits February 28, 2022 14:52

Added new plugin for smartcar.

30d5315

Added switch for TestMode in plugin settings

5bbc364

Used hashin <package> for requirements.txt Added dpkg files for smartcar package

Pinned all requirements versions with '=='

7c33225

Updated requirements.txt to fix install on Raspberry Pi

d7fb145

Add missing dependency

3cabc63

mzanetti suggested changes Feb 28, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: New plugin - smartcar#451

WIP: New plugin - smartcar#451
gpaulbot wants to merge 5 commits intomasterfrom
add-smartcar

gpaulbot commented Jul 9, 2021 •

edited

Loading

Uh oh!

nymea-jenkins commented Jul 9, 2021

Uh oh!

CLAassistant commented Jul 9, 2021 •

edited

Loading

Uh oh!

Uh oh!

mzanetti commented Jul 9, 2021 •

edited

Loading

Uh oh!

mzanetti Feb 28, 2022

Uh oh!

mzanetti Feb 28, 2022

Uh oh!

mzanetti Feb 28, 2022

Uh oh!

mzanetti Feb 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gpaulbot commented Jul 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nymea-jenkins commented Jul 9, 2021

Uh oh!

CLAassistant commented Jul 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mzanetti commented Jul 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mzanetti Feb 28, 2022

Choose a reason for hiding this comment

Uh oh!

mzanetti Feb 28, 2022

Choose a reason for hiding this comment

Uh oh!

mzanetti Feb 28, 2022

Choose a reason for hiding this comment

Uh oh!

mzanetti Feb 28, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gpaulbot commented Jul 9, 2021 •

edited

Loading

CLAassistant commented Jul 9, 2021 •

edited

Loading

mzanetti commented Jul 9, 2021 •

edited

Loading