You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wonder if we can just use the manifestPath here rather than add a new dist property? They will both always point to the same thing, and we can just strip the manifest.json off of it, and things will "just work" without people needing to reconfigure anything or adding a mostly redundant additional config setting.
(In retrospect, it would have made sense from the beginning to have just a dist property, and determine the manifest from there but... alas that ship has sailed).
This plugin has both a Craft v3 and a Craft v4 version, so I'll need to port any changes to develop to develop-v4 also, or you can do dual PRs
The documentation needs to be updated for both Craft v3 and Craft v4
I'm happy to do the latter 2 bullet points, but want to figure out the first one before proceeding
I wonder if we can just use the manifestPath here rather than add a new dist property? They will both always point to the same thing, and we can just strip the manifest.json off of it, and things will "just work" without people needing to reconfigure anything or adding a mostly redundant additional config setting.
Stripping manifestPath makes sense to me! The new config does seem a bit redundant (isn't hindsight a bastard) and the impact will be minimal, as it only affects people using this new option!
Do you want to make the changes to the PR? You have a test case that you can confirm works, ya?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All of the actual work is over in craft-plugin-vite!