Set detected Content-Type only when not already set #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce a condition to set the
Content-Typeheader, backed by a new test.The goal is to have the identical behavior as the http/server and http/fs does.
Content-Typeheader will only be set with the detected MIME type if it is not already set, which means no header previously set (at all).So the condition to set the header is when there is no existing key for the
Content-Typeheader in the response writer map.The purpose of handling the nil value could be seen as the capacity to disable content type detection, and at the same time, not having the
Content-Typeheader in the resulting response for the client.