Skip to content

Conversation

@mwildehahn
Copy link

Fix for: #230. I ran the react 19 codemod: npx codemod react/19/replace-default-props --target src within the repo.

Copy link

@vishnu-sreenivasan vishnu-sreenivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgergen
Copy link
Collaborator

bgergen commented May 8, 2025

@mwildehahn Thanks for submitting this PR, and apologies for taking so long to get to it! Any idea whether this will cause the inverse to happen for older versions of React, i.e. will versions < 18 warn that defaultProps are missing? I'm wondering whether we should update the React peer dependency to just be ^18.0.0 (and maybe remove the prop-types peer dep altogether).

cc @tizmagik

@keminming
Copy link

Raised another PR #234 removing both defaultProps and prop-types. Can we prioritize on fixing this issue as it's a blocker for our react upgrade. Thanks.

@tizmagik
Copy link
Collaborator

tizmagik commented Aug 9, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants