TOOLS: Handle several issue related to running scripts on Windows#127
Merged
Conversation
6c34a6d to
0d325ef
Compare
0d325ef to
26dac33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
*in paths on disk full-stop. This meant that checking out the assets repository on Windows would fail due to water textures using this pattern. The workaround employed is to use$in place of the asterisk, then during build copy away to/tmp/on the docker container and restore the asterisk where Windows will not see it and complain. Added a test case to check for these asterisks too.Visual Sample
N/A (see builds)
Checklist