SERVER: Introduce FTE reimplementation of Vril achievement builtin; early-out achievements#126
Merged
Merged
Conversation
…arly-out achievements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Minimal refactoring to introduce new strategy for unifying parts of FTE/Vril QuakeC via
fte_builtins. This was meant to catch and reproduce nzp-team/nzportable#1138 outside of Vril, but it's clear there is some greater issue that is difficult to triage. This PR mainly disables achievement functionality since there is no UX for it anyway, which will mitigate this problem for the time being. :(Visual Sample
Checklist