SERVER: Ensure PlayerSpawn() only resets rounds when appropriate#132
Closed
tanuki-billie wants to merge 1 commit into
Closed
SERVER: Ensure PlayerSpawn() only resets rounds when appropriate#132tanuki-billie wants to merge 1 commit into
PlayerSpawn() only resets rounds when appropriate#132tanuki-billie wants to merge 1 commit into
Conversation
tanuki-billie
changed the title
PlayerSpawn() only resets rounds when appropriate
MotoLegacy
requested changes
Jun 25, 2025
Member
MotoLegacy
left a comment
MotoLegacy
left a comment
There was a problem hiding this comment.
Minor question and comment revision, otherwise LGTM
| // This prevents the round resetting whenever a player joins the game. | ||
| // (https://github.com/nzp-team/nzportable/issues/1185) | ||
| // | ||
| void() Test_Round_PlayerSpawnSetsRoundProperly = |
Member
There was a problem hiding this comment.
Did you confirm that this test functioned properly (failed) before writing your fix?
Contributor
Author
There was a problem hiding this comment.
No, I hadn't. The test still passes when the change is reverted. I'll need to go back and revise the test (and the code).
| // | ||
| // Test_Round_PlayerSpawnSetsRoundProperly() | ||
| // Validate that PlayerSpawn() only sets the round when needed (at the game start). | ||
| // This prevents the round resetting whenever a player joins the game. |
Member
There was a problem hiding this comment.
No need for this line because this isn't fixing or preventing anything, just testing its behaviors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds an additional guard for rounds being updated in
PlayerSpawn()so that rounds aren't erroneously reset when a player joins a multiplayer game (nzp-team/nzportable#1185). Also adds a relevant unit test in a file for round-specific logic.Visual Sample
round.progression.trimmed.mp4
Checklist