SERVER: No longer update perk machine angles on Soft_Restart. fixes nzp-team/nzportable#1193#143
Merged
Merged
Conversation
This is done when the perk is initially spawned, so there is no need to update the angles again.
sbeeds
changed the title
sbeeds
changed the title
Member
|
Can you write or adjust an existing unit test and confirm that the test fails before your fix, and passes after? |
Contributor
Author
|
I have included a unit test and verified that this test fails prior to changes, and passes after changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Changed
GameRestart_TurnPerkOffto not update angles of perks, since they are already set when the machine is spawned in.This change has been tested in co-op with players leaving/joining and on solo.
Visual Sample
Soft reloading the game while perk is still present:
2025-10-10.00-13-54.mp4
Soft reloading the game after perk has left (bought QR 3 times):
2025-10-10.00-13-32.mp4
Checklist