SERVER: PHD Flopper fix#159
Conversation
nzp-team/nzportable#1363 Fix ready for testing
Fixed comment typo
Changed the perk damage type to other for easier detection
|
Sorry if it causes any problems, but I had to change the damage type of the perk :) |
Says on the tin, implemented a new damage type for to fix this bug without compatibility problems with other weapons
| #define DMG_SCORE_GRENADE 50 // Death by Grenade. | ||
| #define DMG_SCORE_EXPLOSIVE 60 // Death by Explosive Weapon. | ||
| #define DMG_SCORE_TESLA 50 // Death by Tesla. | ||
| #define DMG_SCORE_FLOPPER 50 // Death by PhD Flopper |
There was a problem hiding this comment.
Gamemode_Festive_ScoreForDamage will need modified to add support for this type and return 90 points.
There was a problem hiding this comment.
Understood
| } | ||
| }; | ||
|
|
||
| void(entity attacker, float death_style) Gamemode_GunGame_DieHandler = |
There was a problem hiding this comment.
Flopper isn't a guaranteed kill in the later rounds. Do you get points awarded for non-killing PhD damage too?
There was a problem hiding this comment.
No, it does not currently. Should it be that way?
MotoLegacy
left a comment
MotoLegacy
left a comment
There was a problem hiding this comment.
Left a couple comments. Would you also mind adding some unit tests to test_score.qc to make sure we always return 0 for PhD Flopper damage/kills in Gun Game, and 90 for kills in Festive? And update Test_AddScore_DamageTypes to reflect your new type?
Feel free to ask for help on this.
MotoLegacy
left a comment
MotoLegacy
left a comment
There was a problem hiding this comment.
Still missing the required additional unit tests I asked for to for your new behaviors. Otherwise LGTM.
For clarity's sake
2 participants
Description of Changes
SERVER: Possible fix for PHD flopper explosions contributing to gun game scores, and thus wrongly upgrading tiers.
Visual Sample
Checklist