Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 16, 2025

Description

Renamed package names in Cargo.toml to use mina- prefix for namespace clarity when publishing to crates.io:

  • climina-cli
  • nodemina-node
  • p2pmina-p2p
  • snarkmina-snark
  • vrfmina-vrf

Implementation: Used the package parameter to maintain existing Rust import paths:

[dependencies]
node = { path = "../node", package = "mina-node" }
vrf = { path = "../vrf", package = "mina-vrf" }

This allows code to continue using use node:: while the crate publishes as mina-node.

Directory names unchanged to preserve build script module paths.

Related Issue(s)

N/A

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Refactoring (no functional changes)
  • Build-related changes
  • Performance improvement

Testing

  • cargo check --workspace - all crates compile successfully
  • cargo build --package mina-cli - binary builds correctly
  • Code review - no issues found
  • CodeQL security scan - no vulnerabilities detected

Changelog Entry

Changelog Summary:

  • Changed: Renamed crate packages to use mina- prefix (cli→mina-cli, node→mina-node, p2p→mina-p2p, snark→mina-snark, vrf→mina-vrf) for crates.io namespace clarity

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https /home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libstd-225863f279df55c4.rlib /home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libpanic_unwind-932f22f820d1e5ec.rlib /home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libobject-2dc10b344e05b569.rlib /home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libmemchr-09f2ab7e0d97e07a.rlib /home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libaddr2line-11d54e777384a9e5.rlib /home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libgimli-35018e994bad7042.rlib /home/REDACTED/.rustup/toolchains/1.92-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib/libcfg_if-6a40188dd7d989d2.rlib 86649edc37dd.libp2p_swarm_derive.f7b4d191366f6cb7-cgu.0.rcgu.o 86649edc37dd.libp2p_swarm_derive.f7b4d191366f6cb7-cgu.1.rcgu.o 86649edc37dd.libp2p_swarm_derive.f7b4d191366f6cb7-cgu.2.rcgu.o 86649edc37dd.libp2p_swarm_derive.f7b4d191366f6cb7-cgu.3.rcgu.o b/ru�� 86649edc37dd.6372o89i0r38fnf5u3flqb44q.rcgu.o b/rustlib/x86_64--eh-frame-hdr n/rustc cf9f87a95e4fd2.rlib .rlib rlib 1.rlib (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Rename crate packages to use mina- prefix consistently</issue_title>
<issue_description> Follow-up to the repository restructuring. Rename crate packages (in Cargo.toml [package] name) to use a consistent mina- prefix for all Mina-specific crates:

Current → Proposed:

  • cli → mina-cli
  • node → mina-node
  • p2p → mina-p2p
  • snark → mina-snark
  • vrf → mina-vrf

This will:

  • Provide namespace clarity when published to crates.io
  • Make it clear which crates belong to the Mina project
  • Align with existing naming (mina-core, mina-p2p-messages, mina-tree)

Note: Directory names remain unchanged (e.g., crates/node/) to avoid issues with Rust module paths in build scripts.</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Rename crate packages to use mina- prefix consistently Rename crate packages to use mina- prefix consistently Dec 17, 2025
Copilot AI requested a review from dannywillems December 17, 2025 00:25
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ❌ Validation failed

Click to see full validation output
Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: e099ecd8d03b739b98c74a6f383504a759a9740a

Validating references...
========================
✓ VALID: crates/ledger/src/account/account.rs -> src/lib/mina_base/account.ml L:201-224
  ⚠ STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: e099ecd8d03b739b98c74a6f383504a759a9740a)
❌ INVALID: crates/ledger/src/scan_state/transaction_logic/for_tests.rs
   Code at L:2285-2285 differs between commit 5da42ccd72e791f164d4d200cf1ce300262873b3 and current branch
   Referenced: https://github.com/MinaProtocol/mina/blob/5da42ccd72e791f164d4d200cf1ce300262873b3/src/lib/transaction_logic/mina_transaction_logic.ml#L2285-L2285
   Current:    https://github.com/MinaProtocol/mina/blob/compatible/src/lib/transaction_logic/mina_transaction_logic.ml#L2285-L2285
❌ INVALID: crates/ledger/src/scan_state/transaction_logic/for_tests.rs
   Code at L:2351-2356 differs between commit 5da42ccd72e791f164d4d200cf1ce300262873b3 and current branch
   Referenced: https://github.com/MinaProtocol/mina/blob/5da42ccd72e791f164d4d200cf1ce300262873b3/src/lib/transaction_logic/mina_transaction_logic.ml#L2351-L2356
   Current:    https://github.com/MinaProtocol/mina/blob/compatible/src/lib/transaction_logic/mina_transaction_logic.ml#L2351-L2356
❌ INVALID: crates/ledger/src/scan_state/transaction_logic/for_tests.rs
   Code at L:2407 differs between commit 5da42ccd72e791f164d4d200cf1ce300262873b3 and current branch
   Referenced: https://github.com/MinaProtocol/mina/blob/5da42ccd72e791f164d4d200cf1ce300262873b3/src/lib/transaction_logic/mina_transaction_logic.ml#L2407-L2407
   Current:    https://github.com/MinaProtocol/mina/blob/compatible/src/lib/transaction_logic/mina_transaction_logic.ml#L2407-L2407
✓ VALID: crates/ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e099ecd8d03b739b98c74a6f383504a759a9740a)
✓ VALID: crates/ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e099ecd8d03b739b98c74a6f383504a759a9740a)
✓ VALID: crates/ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e099ecd8d03b739b98c74a6f383504a759a9740a)
✓ VALID: crates/ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e099ecd8d03b739b98c74a6f383504a759a9740a)
✓ VALID: crates/ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e099ecd8d03b739b98c74a6f383504a759a9740a)
✓ VALID: crates/ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e099ecd8d03b739b98c74a6f383504a759a9740a)
✓ VALID: crates/ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/transaction/transaction.ml L:8-11
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e099ecd8d03b739b98c74a6f383504a759a9740a)
✓ VALID: crates/ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:34-48
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e099ecd8d03b739b98c74a6f383504a759a9740a)
✓ VALID: crates/ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/stake_delegation.ml L:11-13
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e099ecd8d03b739b98c74a6f383504a759a9740a)
✓ VALID: crates/ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:179-181
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e099ecd8d03b739b98c74a6f383504a759a9740a)
✓ VALID: crates/ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:239-243
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e099ecd8d03b739b98c74a6f383504a759a9740a)
✓ VALID: crates/ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:352-362
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: e099ecd8d03b739b98c74a6f383504a759a9740a)

Summary
=======
Total references found: 16
Valid references: 13
Invalid references: 3
Stale commits: 13

❌ Validation failed: 3 invalid reference(s) found

@github-actions
Copy link

github-actions bot commented Dec 17, 2025

⚠️ Code Reference Verification Failed

The documentation contains code references that do not match the current state of the codebase on the develop branch.

Issues Found

  • website/docs/developers/referencing-code-in-documentation.md:36 - File not found: ledger/src/scan_state/transaction_logic/valid.rs

Action Required

The code referenced in the documentation must be merged to develop before documentation can be added/modified.

Please follow this workflow:

  1. Merge the code changes to develop first (this PR or a separate code PR)
  2. Create a follow-up PR with the documentation updates that reference the merged code
  3. The verification will pass once the code is available on develop

See the documentation guidelines for more information about the two-PR workflow.

@dannywillems dannywillems marked this pull request as ready for review December 17, 2025 02:30
@dannywillems dannywillems force-pushed the copilot/rename-crate-packages-to-mina-prefix branch from a04442e to 3bb0452 Compare December 17, 2025 02:30
@dannywillems dannywillems moved this to In Review in Rust node Dec 17, 2025
@dannywillems dannywillems force-pushed the copilot/rename-crate-packages-to-mina-prefix branch from b41436e to 869aed8 Compare December 17, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

Rename crate packages to use mina- prefix consistently

2 participants