PopcornFX: FX_EnergyBallTrap_BuildUp and FX_EnergyBallTrap_Projectile sort fixes#418
Closed
HugoPKFX wants to merge 2 commits intoo3de:developmentfrom
Closed
PopcornFX: FX_EnergyBallTrap_BuildUp and FX_EnergyBallTrap_Projectile sort fixes#418HugoPKFX wants to merge 2 commits intoo3de:developmentfrom
HugoPKFX wants to merge 2 commits intoo3de:developmentfrom
Conversation
mbalfour-amzn
approved these changes
May 25, 2023
Contributor
|
You'll need to fix the DCO signing on your commits. |
Author
|
Hi @mbalfour-amzn , Sorry, re-created a different PR with the commit correctly signed this time: #422 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To partially address PopcornFX/O3DEPopcornFXPlugin#43
Fixed source effects that were incorrectly configured (used a
sort by custom sort key, the key was ignoring additional components required by the sorter to work propery - emitter location for instance).To check in the level, this should help.
Unrelated to this fix but I also re-captured the static/animated thumbnails for
FX_MalfunctionningShieldGenerator_ExplosionNote: to review/merge after reviewing/merging #417 to avoid merge issues (I did those modifications after modifications from this other PR).