Makes MPS work again (Without PFX and WWISE) for 26.x#499
Open
nick-l-o3de wants to merge 2 commits intoo3de:developmentfrom
Open
Makes MPS work again (Without PFX and WWISE) for 26.x#499nick-l-o3de wants to merge 2 commits intoo3de:developmentfrom
nick-l-o3de wants to merge 2 commits intoo3de:developmentfrom
Conversation
Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com>
This *REMOVES* PFX and WWISE. Those are still available in the branch `popcornfx-wwise` but will not be maintained unless we get pull requests that fix it. (It hasn't worked quite right in a while). It upgrades it to physx5 because physx4 is deprecated. I had to remove one reference to it inside Script Canvas Energy Ball, and Shield Generator Effects. This adds the missing SkyAtmosphere gem and updates dependencies to be on miniaudio + OpenParticlesystem instead of WWISE + PFX. Note that no particle effects have yet been modified, so there simply are no attached particle effects. We can't yet spawn particles dynamically using OPS (Without a prefab), so I have commented out sections that will require new OPS APIs to work. (See GameEffect.cpp). With this change we expect this project to work out of the box with no further 3rd party additions (just the assets repo) on 26.x, albeit without particle effects or audio to begin with. Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update MPS to be compatible with upcoming 26.x release.
Note that this also requires submission of o3de/o3de-multiplayersample-assets#175
This REMOVES PFX and WWISE. Those are still available
in the branch
popcornfx-wwisebut will not be maintained unless we get pull requests that fix it. (It hasn't workedquite right in several releases. If we can get a aworking version we can always archive a Last Known Good version as an example!)
It upgrades it to physx5 because physx4 is deprecated.
I had to remove one reference to PFX inside Script Canvas. Energy Ball, and Shield Generator Effects.
This adds the missing SkyAtmosphere gem and updates dependencies to be on miniaudio + OpenParticlesystem instead of WWISE + PFX.
Note that no particle effects have yet been modified, so there simply are no attached particle effects.
We can't yet spawn particles dynamically using OPS (Without a prefab), so I have commented out sections that will require
new OPS APIs to work. (See GameEffect.cpp).
With this change we expect this project to work out of the box with no further 3rd party additions (just the assets repo)
on 26.x, albeit without particle effects or audio to begin with. We can then begin updating the effects.
Signed-off-by: Nicholas Lawson 70027408+nick-l-o3de@users.noreply.github.com