core: fix NPE when NvramData is empty #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the is a NvramData row in the db, but without data, the getExternalData() call fails with a NPE: ERROR [org.ovirt.engine.core.bll.HasNvramDataQuery] (default task-179) [4e047baa-c81c-4673-9cd2-6984d0e7477f] Exception: java.lang.NullPointerException at java.base/java.lang.String.<init>(String.java:236) at org.ovirt.engine.core.dal//org.ovirt.engine.core.dao.VmDaoImpl.lambda$getExternalData$6(VmDaoImpl.java:416) This because 'new String(null)' gives this NPE. As we don't need to call 'new' here, just remove it to fix the issue. Signed-off-by: Jean-Louis Dupond <[email protected]>
0ffer
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the is a NvramData row in the db, but without data, the getExternalData() call fails with a NPE:
ERROR [org.ovirt.engine.core.bll.HasNvramDataQuery] (default task-179) [4e047baa-c81c-4673-9cd2-6984d0e7477f] Exception: java.lang.NullPointerException
at java.base/java.lang.String.(String.java:236)
at org.ovirt.engine.core.dal//org.ovirt.engine.core.dao.VmDaoImpl.lambda$getExternalData$6(VmDaoImpl.java:416)
This because 'new String(null)' gives this NPE.
As we don't need to call 'new' here, just remove it to fix the issue.
Fixes issue # (delete if not relevant)
Changes introduced with this PR
Are you the owner of the code you are sending in, or do you have permission of the owner?
[y]