webadmin: added filter to display only not in use LUNs #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An existing problem: When creating a new storage domain, when selecting a LUN, both unused LUNs and used LUNs are shown in the list. Since the list of LUNs can be very large, it is very difficult to search for unused LUNs that can be selected for a storage domain. This happens in the following cases: - selecting a LUN when creating a new storage domain; - selecting a LUN when editing an existing storage domain; - selecting a LUN when creating RDM disks for a VM. Problem solving: The filter "Hide used LUNs" is added to the list of LUNs. When this filter is checked, the list shows only unused LUNs that can be added to the storage domain. This filter is checked by default. Signed-off-by: Evgeniy Kononov <[email protected]>
|
I like the idea. Will try to review asap! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
An existing problem:
When creating a new storage domain, when selecting a LUN, both unused LUNs and used LUNs are shown in the list. Since the list of LUNs can be very large, it is very difficult to search for unused LUNs that can be selected for a storage domain. This happens in the following cases:
- selecting a LUN when creating a new storage domain;
- selecting a LUN when editing an existing storage domain;
- selecting a LUN when creating RDM disks for a VM.
Problem solving:
The filter "Hide used LUNs" is added to the list of LUNs. When this filter is checked, the list shows only unused LUNs that can be added to the storage domain. This filter is checked by default.
Implementation features:
The implementation allows you to expand the LUNs filter, that is, to add additional filter fields.
All interfaces and classes listed below are located in the package org.ovirt.engine.ui.common.widget.ui common.storage.
The ModelFilter interface is the basic filter interface for any entities extending EntityModel. Two filters for LunModel implement the ModelFilter interface: LunFilter (LUN filter itself) and SanTargetFilter (SanTarget filter by the LUN property, which are located inside SanTarget). These filters also extend the basic LUN filter class LunFilterBase, which defines the fields of the LUN filter.
For adding additional LUN filter fields:
- add new filter fields to LunFilterBase;
- extend the LunFilterBase#needFilter() function by checking for new filter fields;
- extend the ModelFilter#filter() function with new filter fields;
- add new filter fields to the UI.
Are you the owner of the code you are sending in, or do you have permission of the owner?
Yes