-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: update GWT to the newer version #992
base: master
Are you sure you want to change the base?
Conversation
I will prepare PR with new dependencies into build-dependencies project a bit lately. |
Done, this is PR with new versions: oVirt/ovirt-engine-build-dependencies#38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
I would split the compiler changes and the version bumps.
And also 2 missing libs in the build-dependencies.
@0ffer : it seems like you will need an additional versioned dependency on gwt-user in frontend/webadmin/modules/pom.xml. |
Some strange thing. There should not be the com.google.gwt dependencies at all. I will try to understand what is going on. |
the gwt-maven-plugin depends on a versioned com.google.gwt. |
Hi! The reason was on other side. |
In new releases there are small fixes and possibility to build it with newer versions of java (up to 21). Signed-off-by: Stanislav Melnichuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out on my test instance with multiple hosts, vms and ISCSI storages and seems to behave like normal.
In new releases there are small fixes and possibility to build it with newer versions of java (up to 21).
With GWT update I aligned maven configuration to build all modules with java-11.
It builded successfully on my machine.
I prepared small setup for testing (one host and one nfs storage domain).
And looked by hands on two browsers (firefox and chrome).
All things looks good for me.
Are you the owner of the code you are sending in, or do you have permission of the owner?
[y/n] y