Conversation
dupondje
force-pushed
the
fix/copr
branch
2 times, most recently
from
124037f to
01b14b2
Compare
Since setuptools v69.3.0, name of the tar file is modified according to PEP 625. Therefor update the code so it builds correctly again with newer setuptools versions. Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Member
Author
|
Builds on COPR work again after this: |
JasperB-TeamBlue
suggested changes
Jul 8, 2025
Contributor
JasperB-TeamBlue
left a comment
JasperB-TeamBlue
left a comment
There was a problem hiding this comment.
I feel like it is against best practice to mix ovirt-imageio and ovirt_imageio. Should it not be better if it was written everywhere one of either way?
Member
Author
That would be indeed :) |
JasperB-TeamBlue
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since setuptools v69.3.0, name of the tar file is modified according to PEP 625. Therefor update the code so it builds correctly again with newer setuptools versions.