Skip to content

webadmin: remove asciidoctor errors and html syntax issues#3221

Merged
dupondje merged 1 commit intooVirt:mainfrom
teamdotblue:remove-html-errors
Mar 9, 2026
Merged

webadmin: remove asciidoctor errors and html syntax issues#3221
dupondje merged 1 commit intooVirt:mainfrom
teamdotblue:remove-html-errors

Conversation

@JasperB-TeamBlue
Copy link
Copy Markdown
Contributor

@JasperB-TeamBlue JasperB-TeamBlue commented Sep 15, 2025

Bug fix

Fixes issue #3000

Changes proposed in this pull request:

  • removed rest-api docs due to it now being hosted on it's own github pages
  • updated headers on files where parameters were not filled in.
  • downgraded leveloffset on certain files to disable too deep of an offset

I confirm that this pull request was submitted according to the contribution guidelines:
@JasperB-TeamBlue

This pull request needs review by:
@sandrobonazzola @dupondje @peter-boden

@sandrobonazzola
Copy link
Copy Markdown
Member

Dropping {URL_virt_product_docs}{URL_format} is likely going to break Oracle documentation based on oVirt docs.
I guess RHV doc is not built from here anymore but just to be sure, let me ask. @oVirt/ovirt-documentation anybody still around?

@sandrobonazzola sandrobonazzola requested a review from a team September 15, 2025 11:44
@dupondje
Copy link
Copy Markdown
Member

@duck-rh :

FROM registry.fedoraproject.org/fedora:33

I guess the production builder does run something more recent? :)

Copy link
Copy Markdown
Member

@peter-boden peter-boden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 remark.

Also one question: what makes it that the absolute path is a problem in these files an not in other spots? (there are a lot more usages of this URL_virt_product_docs var)

Comment thread source/_includes/events_index.haml Outdated
@JasperB-TeamBlue
Copy link
Copy Markdown
Contributor Author

1 remark.

Also one question: what makes it that the absolute path is a problem in these files an not in other spots? (there are a lot more usages of this URL_virt_product_docs var)

In some places this seemed to not be filled in on the local html files but it were functional links on the development server. This fix makes the links relative which removes this issue and improves the surfing experience. All other links could be replaced but were in my opinion not part of the scope for this PR.

@dupondje
Copy link
Copy Markdown
Member

dupondje commented Feb 3, 2026

1 remark.
Also one question: what makes it that the absolute path is a problem in these files an not in other spots? (there are a lot more usages of this URL_virt_product_docs var)

In some places this seemed to not be filled in on the local html files but it were functional links on the development server. This fix makes the links relative which removes this issue and improves the surfing experience. All other links could be replaced but were in my opinion not part of the scope for this PR.

Can't we figure out the cause of this and fix that instead of working around it?
And can you also rebase the PR ? :)

@JasperB-TeamBlue JasperB-TeamBlue force-pushed the remove-html-errors branch 2 times, most recently from 75ace4b to 4938e79 Compare February 11, 2026 11:33
@JasperB-TeamBlue
Copy link
Copy Markdown
Contributor Author

1 remark.
Also one question: what makes it that the absolute path is a problem in these files an not in other spots? (there are a lot more usages of this URL_virt_product_docs var)

In some places this seemed to not be filled in on the local html files but it were functional links on the development server. This fix makes the links relative which removes this issue and improves the surfing experience. All other links could be replaced but were in my opinion not part of the scope for this PR.

Can't we figure out the cause of this and fix that instead of working around it? And can you also rebase the PR ? :)

The cause seemed to be that the affected files were missing some vital headers that were needed to fill in parameters.

* removed rest-api docs due to it now being hosted on it's own github pages
* added doc type specification on files missing it and included reference to attributes where needed.
* downgraded leveloffset on certain files to disable too deep of an offset

Signed-off-by: Jasper Berton <jasper.berton@team.blue>
@dupondje dupondje force-pushed the remove-html-errors branch from 4938e79 to 8c5e710 Compare March 9, 2026 14:22
@dupondje dupondje merged commit e9528f9 into oVirt:main Mar 9, 2026
4 checks passed
@dupondje dupondje deleted the remove-html-errors branch March 9, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants