webadmin: remove asciidoctor errors and html syntax issues#3221
webadmin: remove asciidoctor errors and html syntax issues#3221dupondje merged 1 commit intooVirt:mainfrom
Conversation
|
Dropping |
peter-boden
left a comment
There was a problem hiding this comment.
1 remark.
Also one question: what makes it that the absolute path is a problem in these files an not in other spots? (there are a lot more usages of this URL_virt_product_docs var)
60f32b2 to
341680e
Compare
In some places this seemed to not be filled in on the local html files but it were functional links on the development server. This fix makes the links relative which removes this issue and improves the surfing experience. All other links could be replaced but were in my opinion not part of the scope for this PR. |
Can't we figure out the cause of this and fix that instead of working around it? |
75ace4b to
4938e79
Compare
The cause seemed to be that the affected files were missing some vital headers that were needed to fill in parameters. |
* removed rest-api docs due to it now being hosted on it's own github pages * added doc type specification on files missing it and included reference to attributes where needed. * downgraded leveloffset on certain files to disable too deep of an offset Signed-off-by: Jasper Berton <jasper.berton@team.blue>
4938e79 to
8c5e710
Compare
Bug fix
Fixes issue #3000
Changes proposed in this pull request:
I confirm that this pull request was submitted according to the contribution guidelines:
@JasperB-TeamBlue
This pull request needs review by:
@sandrobonazzola @dupondje @peter-boden