Skip to content

Disable code highlighting #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 21, 2025

Conversation

Totto16
Copy link
Collaborator

@Totto16 Totto16 commented Feb 20, 2025

Description

This completely disables code highlighting so that this version of the extension can be published to EGO.

No new items in the database is stored as CODE but every stored CODE item is displayed as Text.

This also adds a small explanation to the settings.

(Sorry for the German text, but the idea should be clear)
image

cc #278 #271

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • My commits follow the commit standards of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

Attachment

The build package with everything code related disabled, version is set to 23 as the latest release of https://extensions.gnome.org/extension/5278/pano/ is v 22 .

pano@ elhan.io.zip

@Totto16 Totto16 force-pushed the disable_code_highlighting branch from 82dc59c to a05ac89 Compare February 20, 2025 23:34
@Totto16
Copy link
Collaborator Author

Totto16 commented Feb 20, 2025

@oae as discussed in #271 this is the first prototype for removing the code highlighting feature, while still supporting "old" items, that have the CODE value stored as itemType. My suggestion is, to review this, once it is finished and releasable, make a EGO release, that supports gnome 46 and 47. Then afterwards we can tackle #280.

I'll have some time in the next weeks, so I can improve this PR, help with #280 or finally retry #278 😓

I created a separate branch naming it ego_release_preview, it can be renamed, as it was just the first name that came to mind.
The reason for that branch is, that I'd like the master branch to not have this feature disabled, but we can also reverse it, so that we create a branch with highlighting, that users who need it can build from and merge this into master.

I am open for discussion on that topic.

But I'd like to finally tackle the issue, as last week a coworker saw me using this extension and I had to help him install it for like half an hour (on his setup without node and no root 😂), since the latest gnome fedora uses (47) is not on EGO.

@oae
Copy link
Owner

oae commented Feb 21, 2025

@oae as discussed in #271 this is the first prototype for removing the code highlighting feature, while still supporting "old" items, that have the CODE value stored as itemType. My suggestion is, to review this, once it is finished and releasable, make a EGO release, that supports gnome 46 and 47. Then afterwards we can tackle #280.

The changes look good. We can go as you suggested

I'll have some time in the next weeks, so I can improve this PR, help with #280 or finally retry #278 😓

I created a separate branch naming it ego_release_preview, it can be renamed, as it was just the first name that came to mind. The reason for that branch is, that I'd like the master branch to not have this feature disabled, but we can also reverse it, so that we create a branch with highlighting, that users who need it can build from and merge this into master.

I am open for discussion on that topic.

I think it is better this way as well, as you explained it. Additionally, we can create a new action in the new branch that creates releases separately.

But I'd like to finally tackle the issue, as last week a coworker saw me using this extension and I had to help him install it for like half an hour (on his setup without node and no root 😂), since the latest gnome fedora uses (47) is not on EGO.

❤️

@Totto16 Totto16 merged commit 0ce8f2e into oae:ego_release_preview Feb 21, 2025
1 check passed
@Totto16 Totto16 deleted the disable_code_highlighting branch February 21, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants