Toolbar buttons don't show outline when focussed (a11y)#13
Open
sathomas wants to merge 4 commits intooaeproject:masterfrom
sathomas:issue13
Open
Toolbar buttons don't show outline when focussed (a11y)#13sathomas wants to merge 4 commits intooaeproject:masterfrom sathomas:issue13
sathomas wants to merge 4 commits intooaeproject:masterfrom
sathomas:issue13
Conversation
Contributor
Author
|
@simong maybe you feel like reviewing this since @nicolaasmatthijs is out. Of course, feel free to reassign if you'd prefer. |
Contributor
Author
|
To be clear, this PR does not require the latest version of Etherpad; however, it is version 1.5.6 that has general support for accessibility |
static/css/pad.css
Outdated
There was a problem hiding this comment.
Can we use the same outline style as the one used for the main application (thin dotted, offset -2px)? When I tab through the toolbar without voiceover enable, I don't see an outline at all.
|
Finished review. Back to @sathomas for follow-up |
Contributor
Author
|
back to @nicolaasmatthijs after followup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.