[RHELC-1792] Allow using % character in convert2rhel.ini#1460
Open
bocekm wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1460 +/- ##
=======================================
Coverage 96.17% 96.17%
=======================================
Files 73 73
Lines 5309 5312 +3
Branches 922 923 +1
=======================================
+ Hits 5106 5109 +3
Misses 120 120
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bocekm
changed the title
Venefilyn
approved these changes
Mar 15, 2025
Venefilyn
added
kind/bug-fix
Member
Member
|
/packit retest-failed |
1 similar comment
Member
Author
|
/packit retest-failed |
Member
Author
|
/packit copr-build |
Member
Author
|
/packit test |
bocekm
force-pushed
the
disable-interpolation-in-config-ini
branch
from
64c14d5 to
574a9dd
Compare
Member
Author
|
/packit test |
Member
Author
|
/packit test --labels=sanity |
Member
Author
|
/packit test --labels sanity |
1 similar comment
Member
Author
|
/packit test --labels sanity |
bocekm
force-pushed
the
disable-interpolation-in-config-ini
branch
from
574a9dd to
5af1c2f
Compare
Member
Author
|
/packit test --labels sanity |
Whenever a user entered the % character in the convert2rhel.ini config
file, such as in the RHSM password, convert2rhel failed with an error:
configparser.InterpolationSyntaxError: '%' must be followed by '%' or '(', found: "%<STRING>"
The solution is to disable interpreting the % character as a sign for
string replacement.
Related: https://access.redhat.com/solutions/7107977
bocekm
force-pushed
the
disable-interpolation-in-config-ini
branch
from
5af1c2f to
8bafb75
Compare
Member
Author
|
/packit test --labels sanity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever a user entered the % character in the convert2rhel.ini config file, such as in the RHSM password, convert2rhel failed with an error:
The solution is to disable interpreting the % character as a sign for string replacement.
Related: https://access.redhat.com/solutions/7107977
Jira Issues:
Checklist
[RHELC-]or[HMS-]is part of the PR titleRelease Pendingif relevant