Include mdadm configuration in the upgrade initramfs #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scanfilesfortargetuserspace actor is generalized to allow copying directories in addition to regular files. Also fallback files/directories to copy in case the original file doesn't exist can be specified.
Currently, the mdadm configuration (/etc/mdadm.conf and the alternative location and config dirs, see man mdadm.conf#Files) is explicitly set to not be included in upgrade initramfs (via --nomdadmconf dracut option). However, this might cause errors when there are md raid devices on the system. The configuration files should be compatible between RHEL 7, 8, 9. For example, if md array locations are used in fstab instead of UUIDs: $ cat /etc/mdadm.conf ARRAY /dev/md/boot level=raid1 num-devices=2 UUID=531cea9d:bcb23190:ef4a0f87:65bf90d7 ARRAY /dev/md/root level=raid1 num-devices=2 UUID=4d920d36:ac04845a:2f67ffd8:a6f7a521 $ cat /etc/fstab /dev/md/root / xfs defaults 0 0 /dev/md/boot /boot xfs defaults 0 0 In this case /boot and / can't be properly mounted, because their location is specified in mdadm.conf. Inclusion of mdadm.conf in the upgrade initramfs should fix such problems. The file existence check in the target userspace is performed by dracut. Without the --mdadmconf flag the file wouldn't be included at all since the upgrade initramfs is --nohostonly.
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use To launch regression testing public members of oamg organization can leave the following comment:
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the mdadm configuration (
/etc/mdadm.confand the alternativelocation and config dirs, see
man mdadm.conf#Files) is explicitly set to notbe included in upgrade initramfs (via
--nomdadmconfdracut option).However, this might cause errors when there are md raid devices on the
system.
The configuration files should be compatible between RHEL 7, 8, 9.
For example, if md array locations are used in fstab instead of UUIDs:
In this case
/bootand/can't be properly mounted, because theirlocation is specified in
mdadm.conf.Inclusion of
mdadm.confin the upgrade initramfs should fix such problems.The file existence check in the target userspace is performed by dracut.
Without the
--mdadmconfflag the file wouldn't be included at all sincethe upgrade initramfs is
--nohostonly.