improve fallback mechanism for source version matching #1450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the improvement change originating from PR#1443, @pirat89 wanted me to create this PR so we could discuss it again.
I did not try to run it after the big rebase yet.
When searching in the upgrade paths map by the system version, we had implemented a fallback that allowed the upgrade process to find a target version even if the minor version of the system did not match exactly with the ones defined in the map.
The fallback mechanism was implemented using additional definitions in the map which did not have a minor version explicitly defined and thus would be only used as a fallback when the system version did not match any minor version.
This patch changes this fallback mechanism to instead search in the map by the latest minor version of the system's major version. The additional records are removed from the map as well.