Skip to content

Conversation

@PeterMocary
Copy link
Member

@PeterMocary PeterMocary commented Nov 13, 2025

This is the improvement change originating from PR#1443, @pirat89 wanted me to create this PR so we could discuss it again.

I did not try to run it after the big rebase yet.

When searching in the upgrade paths map by the system version, we had implemented a fallback that allowed the upgrade process to find a target version even if the minor version of the system did not match exactly with the ones defined in the map.

The fallback mechanism was implemented using additional definitions in the map which did not have a minor version explicitly defined and thus would be only used as a fallback when the system version did not match any minor version.

This patch changes this fallback mechanism to instead search in the map by the latest minor version of the system's major version. The additional records are removed from the map as well.

@github-actions
Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the leapp-repository contribution and development guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

When searching in the upgrade paths map by the system version, we had
implemented a fallback that allowed the upgrade process to find a target
version even if the minor version of the system did not match exactly
with the ones defined in the map.

The fallback mechanism was implemented using additional definitions in
the map which did not have a minor version explicitly defined and thus
would be only used as a fallback when the system version did not match
any minor version.

This patch changes this fallback mechanism to instead search in the map
by the latest minor version of the system's major version. The
additional records are removed from the map as well.
@PeterMocary PeterMocary force-pushed the improve-unsupported-source-version-fallback branch from 758c81e to 277abe0 Compare November 13, 2025 14:41
@PeterMocary
Copy link
Member Author

It will need some changes, due to the big changes that happened recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant