Skip to content

Scan and check NVMe devices: handle NVMe-FC & NVMe-pcie #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
pirat89 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Scan and check NVMe devices: handle NVMe-FC & NVMe-pcie #1459

pirat89 wants to merge 2 commits into from

Conversation

@pirat89
Copy link
Member

@pirat89 pirat89 commented Dec 3, 2025 •
edited
Loading

tbd.

Note: feel free to take a look / pre-review the things. consider the scanner & model kind of done. The check actor is literally under heavy development still. All unit tests will be added later.

Jira: https://issues.redhat.com/browse/RHEL-46807

TODO:

  • resolve todos in the nvmecheck actor
  • polish the implementation
  • discuss the implementation with NVMe storage team
  • test the solution on real setups to see how it behaves and whether it's enough
  • create possible reports
  • make linters happy
  • add unit tests
  • update commit msgs properly

@pirat89 pirat89 added this to the 8.10/9.8 milestone Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the leapp-repository contribution and development guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@pirat89 pirat89 added enhancement New feature or request changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant and removed changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant labels Dec 3, 2025
@pirat89
Add new actor: scannvme: To scan NVMe setup
1db1e39 
Introduce new model/message NVMEInfo containing information about
detected NVMe devices and basic configuration.

From the configuration it's loaded information about hostid and
hostnqn if defined. This configuration is mandatory for NVMe-oF
setups.

Devices are scanned directly from /sys/class/nvme/ directory, which
should contain information about all NVMe devices. The gathered
facts are limited to information important for the correct handling
of the IPU with NVMe devices - covering NVMe-FC.

Currently scanned information about each device:
    * device name
    * NVMe transport type
    * sys_path (/sys/class/...) to the device definition

If any of the information is not possible to obtain just log an error
message and skip the device - the issue is theoretical and it's not
expected to happen in real. But leaving log messages so in case of
issues we leave visible clues.

Jira-ref: RHEL-46807
@pirat89
Check NVMe devices: handle NVMe-FC and NVMe-pci
0dfa695 
TBD

Jira-ref: RHEL-46807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

8.10/9.8

Development

Successfully merging this pull request may close these issues.

1 participant

@pirat89