[Branch-1.2] Port #9868 for min/max agg func support #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ox/functions/prestosql/aggregates/MinMaxAggregates.cpp Add min, max Spark aggregate functions (facebookincubator#9868) Summary: There are two semantic differences between Presto and Spark. 1. Nested NULLs are compared as values in Spark and as "unknown value" in Presto. 2. The timestamp type represents a time instant in microsecond precision in Spark, but millisecond precision in Presto. Therefore, we need to implement min and max functions for Spark. In this PR, 1. Move Presto `min` and `max` aggregation function implements to lib folder. 2. Add `getMinFunctionFactory` and `getMaxFunctionFactory` which allow callers to register max & min functions with different behaviors. Pull Request resolved: facebookincubator#9868 Reviewed By: mbasmanova Differential Revision: D60051468 Pulled By: kevinwilfong fbshipit-source-id: 1f056420d6909174a35d336e4e1b413a87ef7665
weiting-chen
changed the title
PHILO-HE
approved these changes
Nov 14, 2024
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port facebookincubator#9868 for min/max agg func support