Skip to content

fix: user service strips none, so we need to use a 'real' username - #47

Merged
Alzpeta merged 2 commits into
mainfrom
temporary-username-fix
Jun 18, 2026
Merged

fix: user service strips none, so we need to use a 'real' username#47
Alzpeta merged 2 commits into
mainfrom
temporary-username-fix

Conversation

@mesemus

@mesemus mesemus commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

This fix can be removed when inveniosoftware/invenio-users-resources#207 gets merged.

@mesemus
mesemus requested a review from Alzpeta June 18, 2026 07:25
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.86%. Comparing base (f656e80) to head (aef70ae).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...oidc_einfra/services/components/aai_invitations.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   66.15%   65.86%   -0.30%     
==========================================
  Files          23       23              
  Lines        1445     1453       +8     
  Branches      185      185              
==========================================
+ Hits          956      957       +1     
- Misses        489      496       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Alzpeta
Alzpeta merged commit 091d963 into main Jun 18, 2026
10 of 12 checks passed
@Alzpeta
Alzpeta deleted the temporary-username-fix branch June 18, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants