go: Per-role quote policies by martintomazic · Pull Request #6410 · oasisprotocol/oasis-core

martintomazic · 2025-11-24T21:00:58Z

Wip.

Closes #6387, follows #6331

Status:
This is ready for preliminary high level review, mainly I would like us to focus on the TODO, that I also explained under Challenges in the design doc.

Once we align on the requirements, and finalize some implementation/design decision I will write the final code and thorough test suite, given this is security critical PR. Please ignore style and code quality until then.

netlify · 2025-11-24T21:01:03Z

✅ Deploy Preview for oasisprotocol-oasis-core canceled.

Name	Link
🔨 Latest commit	`750e25a`
🔍 Latest deploy log	https://app.netlify.com/projects/oasisprotocol-oasis-core/deploys/69664e8a52160c00086b46c6

martintomazic · 2025-11-24T21:08:47Z

go/common/node/sgx.go

 	rak signature.PublicKey,
 	rek *x25519.PublicKey,
-	nodeID signature.PublicKey,
+	n *Node,


NIT: Followed the pattern from the admission policy. Alternative is to pass nodeID and roles (bitmask) by value.

Passing whole struct by reference feels dangerous as accidental mutations in the helper functions (possibly in the future) may affect the logic upstream.

codecov · 2025-11-26T11:15:02Z

Codecov Report

❌ Patch coverage is 55.96330% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.51%. Comparing base (d13337b) to head (9e35bd3).

Files with missing lines	Patch %	Lines
go/common/node/sgx.go	23.07%	7 Missing and 3 partials ⚠️
go/common/sgx/quote/quote.go	44.44%	10 Missing ⚠️
go/registry/api/api.go	25.00%	2 Missing and 4 partials ⚠️
go/registry/api/sanity_check.go	58.33%	2 Missing and 3 partials ⚠️
go/common/node/tee.go	20.00%	3 Missing and 1 partial ⚠️
...onsensus/cometbft/apps/keymanager/secrets/epoch.go	50.00%	1 Missing and 1 partial ⚠️
go/consensus/cometbft/apps/registry/messages.go	50.00%	1 Missing and 1 partial ⚠️
...o/consensus/cometbft/apps/registry/transactions.go	84.61%	1 Missing and 1 partial ⚠️
go/consensus/cometbft/apps/scheduler/scheduler.go	71.42%	1 Missing and 1 partial ⚠️
...sensus/cometbft/apps/supplementarysanity/checks.go	60.00%	1 Missing and 1 partial ⚠️
... and 3 more

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #6410       +/-   ##
===========================================
+ Coverage        0   64.51%   +64.51%     
===========================================
  Files           0      698      +698     
  Lines           0    68130    +68130     
===========================================
+ Hits            0    43955    +43955     
- Misses          0    19130    +19130     
- Partials        0     5045     +5045

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

martintomazic · 2025-12-02T10:00:05Z

runtime/src/identity.rs

+    // TODO Add per role quote policy.
+    // But if the runtime cannot trust the host how can it obtain the "role" that is being used for?
+    // Query consensus registry using `node_id`, to obtain the current node struct and thus it's roles?
+    // But the host could set any node_id...


cc @peternose | @kostko.

It needs to query verified consensus state via the consensus verifier.

The host cannot spoof the node ID as it is included in the TEE capability which includes a node ID which is checked during on-chain registration.

Binding generated during attestation:

oasis-core/runtime/src/attestation.rs

Lines 143 to 150 in f73f73c

// Sign the report data, latest verified consensus height, REK and host node ID.

let consensus_state = self.consensus_verifier.latest_state().await?;

let height = consensus_state.height();

let rek = self.identity.public_rek();

let h = SGXAttestation::hash(&verified_quote.report_data, &node_id, height, &rek);

let signature = self.identity.sign(ATTESTATION_SIGNATURE_CONTEXT, &h)?;

Ok(Body::RuntimeCapabilityTEERakQuoteResponse { height, signature })

And verified by consensus during each registration refresh:

oasis-core/go/common/node/sgx.go

Line 250 in f73f73c

return sa.verifyAttestationSignature(sc, rak, rek, verifiedQuote.ReportData, nodeID, height)

We could also change the way the host returns its identity by having the runtime produce a nonce which the host must sign using a special context and return the signature together with the public key. This would prove the host has access to the private key.

Observe that already prior to this commit consensus and runtime quote verification with regards to runtime constaints were not symetric. Consensus part in addition to the runtime constrains may also apply default constaints from the consensus parameters. The runtime part on the other hand only applies runtime constraints. Currently, this is not problematic as as default policy as per the consensus parameters is nil, but this may change in the future. Nit: I would change to sc.ApplyDefaultConstraints(cfg.SGX), as normaly the mutated part should be pointer receiver.

Alternative would be to pass the expected roles during initialization and bypass using host protocol.

This verification was redundant, possibly causing confusing logs.

peternose

You can ignore comments, as I overlooked your instructions.

go/common/node/tee.go

go/common/sgx/quote/quote.go

go/common/node/sgx.go

go/common/sgx/pcs/policy.go

go/common/node/sgx.go

martintomazic commented Nov 24, 2025

View reviewed changes

martintomazic mentioned this pull request Nov 25, 2025

go/common/sgx/pcs/policy: Add FMSP whitelist to quote policy #6331

Merged

martintomazic added the c:breaking/consensus Category: breaking consensus changes label Nov 25, 2025

martintomazic force-pushed the martin/feature/per-role-quote-policies branch from fddedc5 to 9e35bd3 Compare November 26, 2025 10:18

martintomazic force-pushed the martin/feature/per-role-quote-policies branch 2 times, most recently from 13d201f to 5aec2d9 Compare December 2, 2025 09:57

martintomazic commented Dec 2, 2025

View reviewed changes

martintomazic force-pushed the martin/feature/per-role-quote-policies branch from 5aec2d9 to db8d2a6 Compare December 16, 2025 12:04

martintomazic mentioned this pull request Dec 16, 2025

Key manager should use runtime quote policy #6317

Open

martintomazic added 7 commits January 13, 2026 14:40

go/common/node: Fix possible nil dereference

2cdd42a

go/common/sgx/pcs: Add new Merge method to QuotePolicy

df66a06

go: Add support for per-role quote policies

a6c9736

runtime/src: Prototype per-role quote policies

8489f61

Pass roles from the host for the RHP initialization

0949ddc

Alternative would be to pass the expected roles during initialization and bypass using host protocol.

go/registry/api: Verify attestation only when needed

750e25a

This verification was redundant, possibly causing confusing logs.

martintomazic force-pushed the martin/feature/per-role-quote-policies branch from db8d2a6 to 750e25a Compare January 13, 2026 13:54

peternose reviewed Feb 4, 2026

View reviewed changes

martintomazic removed the c:breaking/consensus Category: breaking consensus changes label Feb 24, 2026

martintomazic mentioned this pull request Mar 5, 2026

Per role quote policies #6471

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

go: Per-role quote policies #6410

go: Per-role quote policies #6410
martintomazic wants to merge 7 commits intomasterfrom
martin/feature/per-role-quote-policies

martintomazic commented Nov 24, 2025 •

edited

Loading

Uh oh!

netlify bot commented Nov 24, 2025 •

edited

Loading

Uh oh!

martintomazic Nov 24, 2025 •

edited

Loading

Uh oh!

codecov bot commented Nov 26, 2025

Uh oh!

martintomazic Dec 2, 2025

Uh oh!

martintomazic Dec 2, 2025

Uh oh!

kostko Dec 5, 2025

Uh oh!

peternose left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// Sign the report data, latest verified consensus height, REK and host node ID.
	let consensus_state = self.consensus_verifier.latest_state().await?;
	let height = consensus_state.height();
	let rek = self.identity.public_rek();
	let h = SGXAttestation::hash(&verified_quote.report_data, &node_id, height, &rek);
	let signature = self.identity.sign(ATTESTATION_SIGNATURE_CONTEXT, &h)?;

	Ok(Body::RuntimeCapabilityTEERakQuoteResponse { height, signature })

Conversation

martintomazic commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for oasisprotocol-oasis-core canceled.

Uh oh!

martintomazic Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 26, 2025

Codecov Report

Uh oh!

martintomazic Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

martintomazic Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

kostko Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

peternose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

martintomazic commented Nov 24, 2025 •

edited

Loading

netlify bot commented Nov 24, 2025 •

edited

Loading

martintomazic Nov 24, 2025 •

edited

Loading