chore(deps-dev): bump @types/vscode from 1.99.1 to 1.120.0#65
chore(deps-dev): bump @types/vscode from 1.99.1 to 1.120.0#65dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [@types/vscode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/vscode) from 1.99.1 to 1.120.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/vscode) --- updated-dependencies: - dependency-name: "@types/vscode" dependency-version: 1.120.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe ChangesTypeScript typings update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 1857: The package.json currently pins "@types/vscode" to 1.120.0 while
engines.vscode is "^1.99.0", causing a type/runtime mismatch; pick one fix:
either downgrade the dependency to "@types/vscode" matching the declared minimum
(e.g., set "@types/vscode" to 1.99.x) so typechecking only uses APIs available
in VS Code ^1.99.0, or raise the declared minimum engine by updating
engines.vscode to match the types package (e.g., change engines.vscode to
^1.120.0) so the runtime guarantee aligns with the typings; update package.json
accordingly and run a fresh install and a typecheck to verify no remaining API
mismatches.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f75aa534-77d8-416e-b563-a8fb98b64270
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
| "@types/mocha": "10.0.10", | ||
| "@types/node": "24.12.3", | ||
| "@types/vscode": "1.99.1", | ||
| "@types/vscode": "1.120.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
python - <<'PY'
import json, re, sys
with open("package.json", "r", encoding="utf-8") as f:
pkg = json.load(f)
engine = pkg.get("engines", {}).get("vscode", "")
types = pkg.get("devDependencies", {}).get("@types/vscode", "")
def parse(v: str):
m = re.search(r'(\d+)\.(\d+)\.(\d+)', v or "")
return tuple(map(int, m.groups())) if m else None
e = parse(engine)
t = parse(types)
print(f"engines.vscode: {engine}")
print(f"@types/vscode: {types}")
if not e or not t:
print("ERROR: Could not parse one or both semver values.")
sys.exit(2)
if (t[0], t[1]) > (e[0], e[1]):
print("FAIL: typings target a newer VS Code minor than the declared engine floor.")
sys.exit(1)
print("PASS: no typings/engine floor mismatch detected.")
PYRepository: oaslananka/kicad-studio
Length of output: 190
Align VS Code typings with the declared minimum engine version.
@types/vscode is pinned to 1.120.0 (line 1857), while the extension declares support from ^1.99.0 (line 8). This creates a runtime compatibility risk: code will typecheck against APIs added in VS Code 1.100–1.120 but fail for users on the supported VS Code 1.99–1.119 range.
Either downgrade the type definitions to match the declared minimum or raise the engine requirement. Choose one:
Option 1: Keep types at minimum version
--- a/package.json
+++ b/package.json
@@ -1855,7 +1855,7 @@
"@types/node": "^20.0.0",
- "@types/vscode": "1.120.0",
+ "@types/vscode": "1.99.1",
"eslint": "^8.45.0",Option 2: Raise minimum supported version
--- a/package.json
+++ b/package.json
@@ -6,7 +6,7 @@
"vscode": "^1.120.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@types/vscode": "1.120.0", | |
| "@types/vscode": "1.99.1", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 1857, The package.json currently pins "@types/vscode"
to 1.120.0 while engines.vscode is "^1.99.0", causing a type/runtime mismatch;
pick one fix: either downgrade the dependency to "@types/vscode" matching the
declared minimum (e.g., set "@types/vscode" to 1.99.x) so typechecking only uses
APIs available in VS Code ^1.99.0, or raise the declared minimum engine by
updating engines.vscode to match the types package (e.g., change engines.vscode
to ^1.120.0) so the runtime guarantee aligns with the typings; update
package.json accordingly and run a fresh install and a typecheck to verify no
remaining API mismatches.
![oaslananka-repo-ops[bot]](https://avatars.githubusercontent.com/in/3649470?s=60&v=4){kind=small}
Bumps @types/vscode from 1.99.1 to 1.120.0.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)