replaced audience in request with the name aud to match the claim nam… #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in the txn-token
Closed
PieterKas
reviewed
Dec 4, 2025
|
|
||
| * `grant_type` REQUIRED. The value MUST be set to `urn:ietf:params:oauth:grant-type:token-exchange`. | ||
| * `audience` REQUIRED. The value MUST be set to the Trust Domain name. | ||
| * `aud` REQUIRED. The value MUST be set to the identifier of the Trust Domain. |
Collaborator
There was a problem hiding this comment.
@tulshi - I think the original name of the. parameter is correcthere - RFC 8693 defines the "audience" parameter which is what I thought we are using here?
PieterKas
reviewed
Dec 4, 2025
|
|
||
| grant_type=urn%3Aietf%3Aparams%3Aoauth%3Agrant-type%3Atoken-exchange | ||
| &requested_token_type=urn%3Aietf%3Aparams%3Aoauth%3Atoken-type%3Atxn-token | ||
| &audience=http%3A%2F%2Ftrust-domain.example |
Collaborator
There was a problem hiding this comment.
Similar commentas above - "aud" is the claim in the token, "audience" is the parameter defined in RFC 8693
Collaborator
Author
|
closing this PR per Pieter's comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e in the txn-token