Skip to content

Addresses nested transaction losing error information #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tfwright wants to merge 1 commit into from
+16 −2
Closed

Addresses nested transaction losing error information #1432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/oban/engines/basic.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,13 @@ defmodule Oban.Engines.Basic do

@impl Engine
def insert_job(%Config{} = conf, %Changeset{} = changeset, opts) do
fun = fn -> insert_unique(conf, changeset, opts) end
if Repo.in_transaction?(conf) do
insert_unique(conf, changeset, opts)
else
fun = fn -> insert_unique(conf, changeset, opts) end

with {:ok, result} <- Repo.transaction(conf, fun), do: result
with {:ok, result} <- Repo.transaction(conf, fun), do: result
end
end

@impl Engine
Expand Down
10 changes: 10 additions & 0 deletions test/oban/engine_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,16 @@
assert job_1.id != job_2.id
assert job_1.id == job_3.id
end

@tag skip: @engine != Basic
@tag :unboxed
@tag oban_opts: [repo: UnboxedRepo]
test "propagating db errors raised when inserting within a multi", %{name: name} do
changeset = Worker.new(%{ref: 1}) |> Ecto.Changeset.put_change(:state, "bogus")

Check warning on line 320 in test/oban/engine_test.exs

View workflow job for this annotation

GitHub Actions / ci (1.19, 28.1, 9.1, 18.3-alpine, gossip, lint) 

Pipe chain should start with a raw value.

Check warning on line 320 in test/oban/engine_test.exs

View workflow job for this annotation

GitHub Actions / ci (1.19, 28.1, 9.1, 18.3-alpine, gossip, lint) 

Use a function call when a pipeline is only one function long.
multi = Oban.insert(name, Multi.new(), :job, changeset)

assert_raise Postgrex.Error, fn -> UnboxedRepo.transaction(multi) end
end
end

describe "insert!/2" do
Expand Down
Loading