Fix instance switching when resolver returns a list#161
Merged
sorentwo merged 2 commits intooban-bg:mainfrom Feb 18, 2026
Merged
Fix instance switching when resolver returns a list#161sorentwo merged 2 commits intooban-bg:mainfrom
sorentwo merged 2 commits intooban-bg:mainfrom
Conversation
handle_event("select-instance") compared name (a string — the inspected
atom from phx-value) against allowed (atoms from resolve_instances/1),
so Enum.member?/2 always returned false and switching silently did nothing.
Fix: convert name back to an atom via Module.safe_concat/1 before the
membership check, consistent with how handle_info({:select_instance, name})
already handles the same value.
Member
|
This should go the other way, ensure it is a string and comparing against a list of strings, rather than converting to an atom. There isn't a guarantee that the attempted instance is actually an atom anyhow (an instance can have any type of term as a name). |
Member
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_event("select-instance") compared name (a string — the inspected atom from phx-value) against allowed (atoms from resolve_instances/1), so Enum.member?/2 always returned false and switching silently did nothing.
Fix: convert name back to an atom via Module.safe_concat/1 before the membership check, consistent with how handle_info({:select_instance, name}) already handles the same value.
This PR may or may not have been written by @claude.