fix(events): use Actor.ID instead of deprecated top-level id field - #22
Merged
Conversation
Docker Engine API 1.47+ dropped the top-level `id` field from container event payloads in favour of `Actor.ID`, causing a KeyError crash in monitor_events() on Docker Engine 29.2.1+. Extract the container ID from Actor.ID with a fallback to the legacy id field so the daemon works on both old and new engine versions. Closes #20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event["id"]withevent["Actor"]["ID"]inmonitor_events()idfield for backward compatibility with older Docker enginesContext
Docker Engine API 1.47 (shipped with Docker Engine 28+) deprecated the top-level
idfield on container event payloads in favour ofActor.ID. On Docker Engine 29.2.1+, the field is no longer present, causing aKeyError: 'id'crash on every container event.See: https://docs.docker.com/engine/deprecated/#ambiguous-event-fields-in-api
Test plan
idis absent) and verify noKeyErroris raised on container start/stop/die eventspytest tests/Closes #20