Restore clap v3 help styling#129
Open
GeorgeTR1 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump clap to version 4.4.1, which allows for custom configuration of the help styles. This allows the style of the help to be restored to how it was in clap v3, with colors rather than just bold and underline. This is how it looks now
There is of course now the possibility of changing the style to whatever you want, but since trashy previously used clap v3 I thought this made sense, and I prefer it to the underline/bold style. If you want to customize the style for trashy specifically, that would be very understandable
This also fixes an issue when using cmd.exe on windows, where the underlines would behave strangely. See clap-rs/clap#4431
While that issue was supposedly fixed in 4.1.10, I still had strange behavior when resizing the console window:
From tests that I did this behavior still exists in the most recent version of clap. Changing to a style that doesn't use underlines fixes it, though, of course. I think that some other terminals have issues with these underlines as well