Sequence encode #148
Merged
Sequence encode #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfantini
commented
Mar 8, 2025
| @@ -22,7 +22,7 @@ TEST_CASE("simple field and sequence optional encoder_v2/decoder_v2","[field_seq | |||
| // 1 : Set Template Id. | |||
| // 1 : Set Field field_1_1 | |||
| // 0 : XXX | |||
| REQUIRE(test_case.encoding(test_1.cref(),"\xE0\x81\x82\x81",true)); | |||
| REQUIRE(test_case.encoding(test_1.cref(),"\xE0\x81\x82\x80",true)); | |||
There was a problem hiding this comment.
Here was an error of encoding and i got different value from the encoding v1.
martinfantini
force-pushed
the
sequence_encode
branch
2 times, most recently
from
64e427a to
5dd2eff
Compare
Merged
martinfantini
force-pushed
the
sequence_encode
branch
from
5dd2eff to
e1331a9
Compare
…ll 0x80 and false in the presence map.
martinfantini
force-pushed
the
sequence_encode
branch
from
e1331a9 to
6171f6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is also a case of encoding optional sequence with none operator.