feat(#5165): add @Impure and annotate impure atoms#5245
Draft
asmirnov-backend wants to merge 2 commits into
Draft
feat(#5165): add @Impure and annotate impure atoms#5245asmirnov-backend wants to merge 2 commits into
@Impure and annotate impure atoms#5245asmirnov-backend wants to merge 2 commits into
Conversation
Marks atoms whose result depends on the outside world so caching decorators like `PhSticky` never memoize them. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
asmirnov-backend
force-pushed
the
5165-impure-annotation
branch
from
June 19, 2026 15:49
519f300 to
052b7f4
Compare
Contributor
🚀 Performance AnalysisAll benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information. Click to see the detailed report
✅ Performance gain: |
Mark the 20 atoms whose result depends on the outside world or mutable state: filesystem (`EOfs`), OS (`EOsm`: os.name, posix, win32) and shared memory (`EOmalloc`). `PhSticky` must never memoize these. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
asmirnov-backend
changed the title
@Impure marker annotation@Impure and annotate impure atoms
|
Contributor
Author
|
@yegor256, could you please take a look |
Open
Member
asmirnov-backend
marked this pull request as draft
June 27, 2026 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5165.
@Impuremarker annotation — it flags atoms whose result depends on the outside world or mutable state.PhStickycaching decorator never memoizes them:EOfs/*(file.*,dir.*);EOsm:os.name,posix.φ,win32.φ;EOmalloc*(read/write/resized/size/of.φ, all viaHeaps.INSTANCE).Pure atoms (arithmetic, math, regex/sprintf/sscanf, error/try) are left un-annotated so they remain cacheable.