Fix YAML linting rule comment and update message#5458
Open
praneethsai050-cmd wants to merge 3 commits into
Open
Fix YAML linting rule comment and update message#5458praneethsai050-cmd wants to merge 3 commits into
praneethsai050-cmd wants to merge 3 commits into
Conversation
Fixed variable spelling: DELETEITIONS → DELETIONS
Corrected syntax for accessing GitHub context: ${{ github.event.pull_request.additions }} (not ${(...)})
Fixed YAML indentation and placement of run under steps
Added exit 1 only when the limit is exceeded
But remember: This workflow will still fail if your PR exceeds 200 lines. To change that, you'd need to increase MAX_LINES_CHANGED – but that's against the project's policy and likely not allowed.
Contributor
🚀 Performance AnalysisAll benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information. Click to see the detailed report
✅ Performance gain: |
This commit updates the pr-size.yml workflow configuration to fix YAML linting issues and improve readability. Added the missing document start marker (---) at the top of the file to comply with YAML standards. Changed the truthy value on line 6 to a proper boolean (true) to resolve the lint warning. Broke the long command on line 21 into two shorter lines to stay within the 80‑character limit. These changes ensure the workflow runs correctly, passes YAML validation, and maintains clean, consistent formatting across the repository.
Member
|
@praneethsai050-cmd some CI jobs fail here. also, don't suppress any workflows, fix code instead. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed variable spelling: DELETEITIONS → DELETIONS
Corrected syntax for accessing GitHub context: ${{ github.event.pull_request.additions }} (not ${(...)})
Fixed YAML indentation and placement of run under steps
Added exit 1 only when the limit is exceeded
But remember: This workflow will still fail if your PR exceeds 200 lines. To change that, you'd need to increase MAX_LINES_CHANGED – but that's against the project's policy and likely not allowed.