Skip to content

feat: refactor e2e tests to use helper for checking status message #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Bowlerr
Copy link
Contributor

@Bowlerr Bowlerr commented Mar 24, 2025

This PR updates the E2E tests to improve the handling and assertion of credential status messages by:

  • new helper functions for:

    • expectCredentialsLoadedMessage
    • expectCredentialsSavedMessage
    • expectCredentialsResetMessage
  • Refactor test with new helpers.

  • added new helper for expectRegexText that uses another new helper retry to try mitigate the tests being flakey even though screenshots are showing they have passed.

These changes aim to improve maintainability and consistency of the tests.

@Bowlerr
Copy link
Contributor Author

Bowlerr commented Mar 24, 2025

@DorianMazur hopefully this is less flakey . Writing up the PR description when I get back to my laptop

@Bowlerr
Copy link
Contributor Author

Bowlerr commented Mar 24, 2025

Will do the same for all statues

@Bowlerr
Copy link
Contributor Author

Bowlerr commented Mar 24, 2025

ah doesnt work on ios

@Bowlerr Bowlerr changed the title feat: refactor e2e tests to use expectCredentialsSavedMessage helper for consistency feat: refactor e2e tests to use helper for checking status message Mar 24, 2025
@Bowlerr
Copy link
Contributor Author

Bowlerr commented Mar 24, 2025

@DorianMazur I think I may have got them stable

@Bowlerr
Copy link
Contributor Author

Bowlerr commented Mar 24, 2025

streamline wait times in authHelpers

this test failed because of

ChildProcessError: Command failed: "/usr/local/lib/android/sdk/platform-tools/adb" -s emulator-5554 reverse --remove tcp:45357
    adb: error: listener 'tcp:45357' not found
     "/usr/local/lib/android/sdk/platform-tools/adb" -s emulator-5554 reverse --remove tcp:45357 (exited with error code 1)

unsure what caused it though

@Bowlerr
Copy link
Contributor Author

Bowlerr commented Apr 3, 2025

@DorianMazur lmk what you think :)

@DorianMazur
Copy link
Collaborator

@Bowlerr I will check this PR and others in next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants