Skip to content

feat(android): add confirmationRequired option to authenticationPrompt #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions android/src/main/java/com/oblador/keychain/KeychainModule.kt
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ class KeychainModule(reactContext: ReactApplicationContext) :
const val SUBTITLE = "subtitle"
const val DESCRIPTION = "description"
const val CANCEL = "cancel"
const val CONFIRMATION_REQUIRED = "confirmationRequired"
}
}

Expand Down Expand Up @@ -779,9 +780,14 @@ class KeychainModule(reactContext: ReactApplicationContext) :
promptInfoBuilder.setNegativeButtonText(it)
}
}

/* Bypass confirmation to avoid KeyStore unlock timeout being exceeded when using passive biometrics */
promptInfoBuilder.setConfirmationRequired(false)
// Default is false — no confirmation required unless explicitly set
var confirmationRequired = false
promptInfoOptionsMap?.let {
if (it.hasKey(AuthPromptOptions.CONFIRMATION_REQUIRED)) {
confirmationRequired = it.getBoolean(AuthPromptOptions.CONFIRMATION_REQUIRED)
}
}
promptInfoBuilder.setConfirmationRequired(confirmationRequired)
return promptInfoBuilder.build()
}

Expand Down
6 changes: 6 additions & 0 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ export type AuthenticationPrompt = {
* @platform Android
*/
cancel?: string;

/** Whether user confirmation (e.g. OK button) is required after authentication.
* Default is `false`.
* @platform Android
*/
confirmationRequired?: boolean;
};

export type BaseOptions = {
Expand Down