Add DOSDP pattern for disease progression traits and seed initial progression terms#423
Draft
Copilot wants to merge 4 commits into
Draft
Add DOSDP pattern for disease progression traits and seed initial progression terms#423Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Agent-Logs-Url: https://github.com/obophenotype/bio-attribute-ontology/sessions/99f20b5c-8a68-4783-b6d5-8aea61a339f5 Co-authored-by: ar-ibrahim <97462656+ar-ibrahim@users.noreply.github.com>
Agent-Logs-Url: https://github.com/obophenotype/bio-attribute-ontology/sessions/99f20b5c-8a68-4783-b6d5-8aea61a339f5 Co-authored-by: ar-ibrahim <97462656+ar-ibrahim@users.noreply.github.com>
Agent-Logs-Url: https://github.com/obophenotype/bio-attribute-ontology/sessions/99f20b5c-8a68-4783-b6d5-8aea61a339f5 Co-authored-by: ar-ibrahim <97462656+ar-ibrahim@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add new trait pattern for disease progression terms
Add DOSDP pattern for disease progression traits and seed initial progression terms
May 8, 2026
aleixpuigb
requested changes
May 11, 2026
Collaborator
aleixpuigb
left a comment
There was a problem hiding this comment.
Please see inline comments.
I am not very used to disease patterns, so maybe it would be good to consult the equivalence axiom with a person who is more knowledgeable with disease.
Not all patterns have extra fiels such as synonyms or ORCID, but I think they should be included. However, this is only a suggestion.
| @@ -0,0 +1,42 @@ | |||
| pattern_name: disease progression | |||
Collaborator
There was a problem hiding this comment.
missing underscore symbol
Suggested change
| pattern_name: disease progression | |
| pattern_name: disease_progression |
| description: 'Trait pattern for disease or phenotype progression terms.' | ||
|
|
||
| classes: | ||
| disease_or_phenotype: owl:Thing |
Collaborator
There was a problem hiding this comment.
As the pattern name is deisease progression, why not disease only?
| biological_attribute: OBA:0000001 | ||
|
|
||
| relations: | ||
| inheres in: RO:0000052 |
Collaborator
There was a problem hiding this comment.
RO:0000052 is 'characteristic_of', although in some ontologies is relabelled as 'inheres_in'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a compositional OBA pattern for disease/phenotype progression so GWAS-style “disease + progression measurement” annotations can be represented as single trait terms. It establishes a reusable template and seeds initial terms to support immediate curation.
New disease progression pattern
src/patterns/dosdp-patterns/disease_progression.yaml.PATO:0002323) inhering in a disease/phenotype filler."[disease/phenotype] progression"and synonym"progression of [disease/phenotype]".AUTO:patterns/patterns/disease_progression).New pattern data table + seeded terms
src/patterns/data/default/disease_progression.tsv.OBA:2100006— disease progression (MONDO:0000001)OBA:2100007— Alzheimer disease progression (MONDO:0004975)Generated ontology updates
src/patterns/definitions.owlto include new class declarations and equivalence axioms from the new pattern/data.Example generated axiom shape:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
docs.google.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either: