Skip to content

Add DOSDP pattern for disease progression traits and seed initial progression terms#423

Draft
Copilot wants to merge 4 commits into
masterfrom
copilot/add-new-trait-pattern-for-disease-progression
Draft

Add DOSDP pattern for disease progression traits and seed initial progression terms#423
Copilot wants to merge 4 commits into
masterfrom
copilot/add-new-trait-pattern-for-disease-progression

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

This introduces a compositional OBA pattern for disease/phenotype progression so GWAS-style “disease + progression measurement” annotations can be represented as single trait terms. It establishes a reusable template and seeds initial terms to support immediate curation.

  • New disease progression pattern

    • Added src/patterns/dosdp-patterns/disease_progression.yaml.
    • Models progression as temporal distribution quality (PATO:0002323) inhering in a disease/phenotype filler.
    • Generates labels as "[disease/phenotype] progression" and synonym "progression of [disease/phenotype]".
    • Includes definition xref annotation (AUTO:patterns/patterns/disease_progression).
  • New pattern data table + seeded terms

    • Added src/patterns/data/default/disease_progression.tsv.
    • Seeded:
      • OBA:2100006 — disease progression (MONDO:0000001)
      • OBA:2100007 — Alzheimer disease progression (MONDO:0004975)
  • Generated ontology updates

    • Regenerated src/patterns/definitions.owl to include new class declarations and equivalence axioms from the new pattern/data.

Example generated axiom shape:

EquivalentClasses(
  <http://purl.obolibrary.org/obo/OBA_2100007>
  ObjectIntersectionOf(
    <http://purl.obolibrary.org/obo/OBA_0000001>
    <http://purl.obolibrary.org/obo/PATO_0002323>
    ObjectSomeValuesFrom(
      <http://purl.obolibrary.org/obo/RO_0000052>
      <http://purl.obolibrary.org/obo/MONDO_0004975>
    )
  )
)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • docs.google.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add new trait pattern for disease progression terms Add DOSDP pattern for disease progression traits and seed initial progression terms May 8, 2026
Copilot AI requested a review from ar-ibrahim May 8, 2026 15:32
@ar-ibrahim ar-ibrahim requested a review from aleixpuigb May 11, 2026 09:30
Copy link
Copy Markdown
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments.
I am not very used to disease patterns, so maybe it would be good to consult the equivalence axiom with a person who is more knowledgeable with disease.
Not all patterns have extra fiels such as synonyms or ORCID, but I think they should be included. However, this is only a suggestion.

@@ -0,0 +1,42 @@
pattern_name: disease progression
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing underscore symbol

Suggested change
pattern_name: disease progression
pattern_name: disease_progression

description: 'Trait pattern for disease or phenotype progression terms.'

classes:
disease_or_phenotype: owl:Thing
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the pattern name is deisease progression, why not disease only?

biological_attribute: OBA:0000001

relations:
inheres in: RO:0000052
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RO:0000052 is 'characteristic_of', although in some ontologies is relabelled as 'inheres_in'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request for a new trait pattern for disease progression terms

3 participants