NTR: reproductive/measurement terms (fundal height, abdominal girth, blood globulin amount)#434
Merged
Conversation
Adds 3 new entity-attribute terms requested by the GWAS Catalog team (via EFO#2526), modeled with the entity_attribute and entity_attribute_location DOSDP patterns: - OBA:2090005 fundal height (height of uterine fundus, NCIT:C154876) - OBA:2090006 abdominal girth (circumference of abdomen, NCIT:C172954) - OBA:2090007 blood globulin amount (amount of globular protein in blood) Fetal heart rate, the 4th requested term, is being modeled in EFO instead since there is no existing GO/UBERON entity for "fetal heart" or "fetal cardiac contraction" to compose a DOSDP pattern with. Refreshed merged imports to pull in UBERON:1200003 (uterine fundus).
ar-ibrahim
requested changes
Jun 29, 2026
ar-ibrahim
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #433. Adds 3 of the 4 requested new OBA terms for GWAS Catalog reproductive/measurement traits (originating from EBISPOT/efo#2526):
OBA:2090005entity_attributeOBA:2090006entity_attributeOBA:2090007entity_attribute_locationDefinition citations (NCIT:C154876, NCIT:C172954) are recorded as xrefs per the proposed parents in the issue. CHEBI has no dedicated "globulin" class, so
globular protein(CHEBI:746933) was used as the closest available filler — globulins are a class of globular proteins.Fetal heart rate (the 4th requested term) is not included here: there is no existing GO/UBERON entity for "fetal heart" or "fetal cardiac contraction" to compose a DOSDP pattern with, so it's being modeled directly in EFO instead.
Test plan
EquivalentClassesaxioms viadosdp-tools generate(make IMP=false MIR=false ../patterns/definitions.owl)make refresh-merged) to pull inUBERON:1200003(uterine fundus)definitions.owlto confirm only the 3 new term blocks (+ version bump) changed🤖 Generated with Claude Code