Skip to content

Add draft pattern for bone length along an axis#81

Open
rays22 wants to merge 27 commits into
masterfrom
issue80
Open

Add draft pattern for bone length along an axis#81
rays22 wants to merge 27 commits into
masterfrom
issue80

Conversation

@rays22
Copy link
Copy Markdown
Contributor

@rays22 rays22 commented Mar 24, 2022

This commit intends to add a yaml template file for DOSDP pattern bone length along an axis.
If applied, this commit will fix #80.

@rays22
Add yaml template file
a3821c6 
This commit intends to add a yaml template file for DOSDP pattern bone length along an axis.
If applied, this commit will fix #80.
@rays22 rays22 self-assigned this Mar 24, 2022
@rays22 rays22 mentioned this pull request Mar 24, 2022
Open
meghalithic
meghalithic reviewed Mar 24, 2022
View reviewed changes
Comment thread src/patterns/dosdp-patterns/boneLengthAlongAxis.yaml Outdated
meghalithic
meghalithic requested changes Mar 24, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@meghalithic meghalithic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just made a change to the def

rays22
rays22 commented Mar 25, 2022
View reviewed changes
Comment thread src/patterns/dosdp-patterns/boneLengthAlongAxis.yaml Outdated
@meghalithic
Copy link
Copy Markdown
Collaborator

meghalithic commented Apr 1, 2022

I am going to include the notes from the other bone length pattern

@meghalithic
Copy link
Copy Markdown
Collaborator

meghalithic commented May 18, 2022

@rays22 why is this failing?

@rays22
Copy link
Copy Markdown
Contributor Author

rays22 commented May 18, 2022

@rays22 why is this failing?

There had been some syntax errors (missing quotes) in your yaml file. I have fixed them in commit f872c13.

@meghalithic
Copy link
Copy Markdown
Collaborator

meghalithic commented Jul 20, 2022

@rays22 can we merge this?

@meghalithic meghalithic changed the title Add yaml template file Add draft pattern for bone length along an axis Jul 20, 2022
@meghalithic meghalithic mentioned this pull request Jul 25, 2022
Open
@meghalithic meghalithic marked this pull request as draft July 25, 2022 18:04
@matentzn matentzn marked this pull request as ready for review August 19, 2022 14:27
matentzn
matentzn requested changes Aug 19, 2022
View reviewed changes
Comment thread src/patterns/dosdp-patterns/boneLengthAlongAxis.yaml Outdated
Comment thread src/patterns/dosdp-patterns/boneLengthAlongAxis.yaml Outdated
Comment thread src/patterns/dosdp-patterns/boneLengthAlongAxis.yaml Outdated
rays22 added 2 commits August 19, 2022 20:51
@rays22
Implement data_lis_vars
6adb96a 
to help annotate definitions with external references.
Fix syntax errors.

Addresses #80.
@rays22
Delete redundant vars and axioms
f5494a2 
Addresses #80.
@rays22 rays22 requested review from matentzn and meghalithic August 19, 2022 21:05
matentzn
matentzn requested changes Aug 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Provide an example tsv file and compile it into OWL to make sure this pattern works

Comment thread src/patterns/dosdp-patterns/boneLengthAlongAxis.yaml Outdated
Comment thread src/patterns/dosdp-patterns/boneLengthAlongAxis.yaml
Comment thread src/patterns/dosdp-patterns/boneLengthAlongAxis.yaml Outdated
@rays22 rays22 mentioned this pull request Aug 24, 2022
Open
rays22
rays22 commented Aug 24, 2022
View reviewed changes
Comment thread src/patterns/dosdp-patterns/boneLengthAlongAxis.yaml Outdated
rays22
rays22 commented Sep 2, 2022
View reviewed changes
Comment thread src/patterns/dosdp-patterns/length_along_axis.yaml
@meghalithic
Copy link
Copy Markdown
Collaborator

meghalithic commented Oct 13, 2022

I just need to rerun the pattern

@meghalithic
Copy link
Copy Markdown
Collaborator

meghalithic commented Jan 24, 2023

@rays22 I think I need a refresher on where we are in this discussion...

@meghalithic
Copy link
Copy Markdown
Collaborator

meghalithic commented Feb 9, 2023

@rays22 I updated the pattern. Can we meet to test the pattern?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matentzn matentzn matentzn requested changes

@dosumis dosumis Awaiting requested review from dosumis

@meghalithic meghalithic Awaiting requested review from meghalithic

Assignees

@rays22 rays22

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add draft pattern for bone length along an axis

3 participants

@rays22 @meghalithic @matentzn