Add HRA small-intestine NTR batch outputs and review reports#3720
Add HRA small-intestine NTR batch outputs and review reports#3720zhengj2007 wants to merge 2 commits into
Conversation
Generated via bulk_ntr_workflow from source_data/small-intestine.csv. Pipeline completed through Stage 4: - 13 input rows processed - 0 new terms remained in final template after merge filtering - 10 confirmed existing UBERON matches excluded - 2 out-of-scope terms excluded - 2 manual-curation entries flagged - 4 name corrections reported Adds the small-intestine source CSV, generated template stubs, and report TSVs (candidates, errors, input, manual_curation, name_corrections, out_of_scope). Signed-off-by: dragon-ai-agent <dragon-ai-agent@users.noreply.github.com>
|
Claude finished @zhengj2007's task in 4m 35s —— View job PR Review: Add HRA small-intestine NTR batch outputs and review reports
Review Checklist
SummaryThis is a well-executed pipeline-output PR. All 13 HRA ASCTB small-intestine input terms have been processed; no new UBERON terms are introduced because every term either already exists, is out-of-scope, or requires manual curation before a new ID can be assigned. The report files are detailed and provide actionable curator guidance. UBERON ID verification (spot-checked via
Issues Found🟡 IMPORTANT: Stage 5 (ODK registration) not completed
🟡 IMPORTANT: "muscularis propria" and "muscularis externa" both map to UBERON:0006660 Two distinct source terms map to the same UBERON ID (muscular coat). While anatomically valid — these are accepted synonyms — the 🔵 SUGGESTION: Empty All 13 rows have an empty 🔵 SUGGESTION: UBERON canonical labels not shown in For matches where the UBERON primary label differs from the source label (e.g., "serosa" → "serous membrane", "submucosal plexus of Meissner" → "submucous nerve plexus"), the candidates report shows only the UBERON ID without the canonical label. Including the UBERON label in a Manual Curation QualityThe two manual-curation entries are well-documented:
Both suggestions follow UBERON design patterns appropriately. RecommendationThis PR is ready to merge. The report files accurately document the pipeline run, the UBERON ID mappings are correct, and the flagged items provide clear curator guidance. The 🟡 issues above are follow-up items, not blockers: ODK registration belongs in the term-addition PR, and the duplicate-mapping note is documentation polish. |
There was a problem hiding this comment.
Well-executed pipeline output PR. All 13 HRA ASCTB small-intestine input terms correctly processed — 10 confirmed matches verified against uberon-edit.obo, 2 out-of-scope terms properly flagged with detailed anatomical reasoning, and 2 manual-curation entries well-documented with specific UBERON term references and actionable suggestions. No new terms added; the templates are empty header stubs pending manual curation follow-up. Two 🟡 notes for follow-up PRs: (1) ODK registration of the new templates should happen when terms are eventually added; (2) candidates.tsv could note that 'muscularis propria' and 'muscularis externa' are synonyms both mapping to UBERON:0006660 to avoid curator confusion.
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
Reports are review artifacts, not ODK templates, and should not live under src/templates/. Relocated to bulk_ntr_workflow/outputs/ to match the canonical layout used by the muscular branch (PR #3700). Signed-off-by: dragon-ai-agent
|
Reports relocated. Automated update (@cellsemantic / dragon-ai-agent, for @dosumis). Reports were relocated out of |
|
Claude finished @dosumis's task in 3m 30s —— View job PR Review: Add HRA small-intestine NTR batch outputs and review reportsTask list
Review Checklist
Answering the open question (cellsemantic, 2026-07-09)Confirmed against the diff ( Given that, this PR is legitimately a "no-op for the ontology, audit-trail only" PR — it doesn't touch Issues Found🟡 IMPORTANT: Two source terms are double-counted across mutually-exclusive report files, breaking the documented QC invariant Per
Neither case is anatomically wrong on its own, but the reports are supposed to be a strict partition of the 13 input rows (that's what the PR description's "10 + 2 + 2" tally assumes, and what a curator scanning file-by-file would assume). A curator working strictly from 🔵 SUGGESTION (carried over, still unaddressed): empty All 13 rows still have an empty 🔵 SUGGESTION (carried over): add a Several matches have a UBERON canonical label that differs from the source label ( 🔵 SUGGESTION (resolved from prior review): ODK registration Correctly deferred — templates are empty, so no registration is needed yet; this is fine as-is until real terms are added in a follow-up. RecommendationNo ontology risk (no axioms, no obsoletions, no ODK/build regression) — this should not be closed, it's useful provenance for a completed pipeline run with genuinely zero new terms. Requesting changes only for the 🟡 report double-counting issue, since it undermines the reliability of the audit trail that is this PR's entire content. Once that's cleaned up (or explicitly cross-referenced), this is mergeable. |
This PR modifies some logical definitions. See details below:Number of classes with modified logical definitions: 1 gABAergic systemNo changes in inferred subclasses. |
There was a problem hiding this comment.
Review Checklist
- Hierarchy and parents are consistent (N/A — no new logical axioms; templates are header-only)
- Definitions and supporting references look adequate (N/A — no new terms)
- Obsolete or replacement handling is safe — N/A, but see report-consistency issue below
- OBO and ODK conventions appear preserved
- No obvious CI, auth, or workflow regression
Re: "should this PR be closed?" — No. git diff 4f80568...HEAD confirms the leaf/groups templates are header-only (0 new terms), and per the stated batch-size policy (<20 new terms → hand-edit) there's nothing to hand-edit since the true new-term count is zero. This PR is a legitimate audit-trail-only record of a completed pipeline run and touches nothing the build consumes (no uberon-edit.obo changes, templates correctly unregistered in uberon-odk.yaml).
🟡 IMPORTANT: muscularis mucosa and circular/longitudinal muscle are each double-counted across mutually-exclusive report files (candidates.tsv vs out_of_scope.tsv; candidates.tsv vs manual_curation.tsv), which breaks the QC invariant documented in bulk_ntr_workflow/CLAUDE.md ("input − confirmed_match − out_of_scope − manual_curation = leaf + group": 13−10−2−2 = −1, not 0). A curator working from only one report file could act inconsistently. Please de-duplicate the categorization or add explicit cross-references between the files.
🔵 SUGGESTION (carried over, unaddressed): input.tsv's table column is empty for all 13 rows despite small-intestine.csv having tables=small-intestine — looks like a column-name mismatch in the generator.
🔵 SUGGESTION (carried over): add a uberon_label column to candidates.tsv for matches where the UBERON canonical label differs from the source label.
No ontology-level risk; requesting changes only to fix the report double-counting so this PR's audit trail is internally consistent before merge.
Generated via bulk_ntr_workflow from source_data/small-intestine.csv.
Pipeline completed through Stage 4:
Adds the small-intestine source CSV, generated template stubs, and report TSVs (candidates, errors, input, manual_curation, name_corrections, out_of_scope).